Repository navigation
Conversation
…endpoints ### Summary of Changes Addresses audit finding **HIGH-2 (CWE-798: Use of Hard-coded Credentials)** by removing third-party RPC endpoints carrying embedded private API keys in `constants/extraRpcs.js`: 1. **Eliminated Key-Bearing Endpoints:** - **Ethereum (Chain 1):** Removed `rpcfast.com` and `chain49.com` endpoints containing hardcoded credentials. - **BNB Smart Chain (Chain 56):** Removed `rpcfast.com` endpoint containing hardcoded credentials. - **Polygon (Chain 137):** Removed `rpcfast.com` endpoint containing hardcoded credentials. - **Velas (Chain 106):** Removed `rpcfast.com` endpoint containing hardcoded credentials. 2. **Security & Reliability Justification:** - Private credentials shipped in public frontend bundles risk unauthorized quota consumption and service disruption. - Ample zero-auth public RPC alternatives remain available in the catalogue for all affected chains. --- ### Follow-Up Recommendations - Revoke and rotate the exposed `rpcfast` and `chain49` keys with the upstream providers. - Implement pre-commit hooks (e.g. `gitleaks` or `git-secrets`) to prevent future key commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Addresses audit finding HIGH-2 (CWE-798: Use of Hard-coded Credentials) by removing third-party RPC endpoints carrying embedded private API keys in
constants/extraRpcs.js:Eliminated Key-Bearing Endpoints:
rpcfast.comandchain49.comendpoints containing hardcoded credentials.rpcfast.comendpoint containing hardcoded credentials.rpcfast.comendpoint containing hardcoded credentials.rpcfast.comendpoint containing hardcoded credentials.Security & Reliability Justification:
Follow-Up Recommendations
rpcfastandchain49keys with the upstream providers.gitleaksorgit-secrets) to prevent future key commits.