Skip to content

Dismiss the iOS native editor when the contact is deleted from it #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liliana-tagonsoft wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dismiss the iOS native editor when the contact is deleted from it #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ios/flutter_contacts/Sources/flutter_contacts/native/impl/ShowEditorImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ enum ShowEditorImpl {
private static var pendingResult: FlutterResult?
private static var editorDelegate: EditorDelegate?
private static var closeHandler: EditorCloseHandler?
private static var storeObserver: NSObjectProtocol?

static func handle(call: FlutterMethodCall, result: @escaping FlutterResult) {
let contactId: String = call.arg("contactId")!
Expand Down Expand Up @@ -35,13 +36,44 @@ enum ShowEditorImpl {
editorDelegate = delegate
closeHandler = handler
navController.modalPresentationStyle = .pageSheet
observeDeletion(of: contactId, keys: keys, in: navController)
rootVC.present(navController, animated: true)
}
return nil
}
}

/// Deleting from the editor's "Delete Contact" row never calls the delegate:
/// the sheet stays up and the caller is left waiting on a contact that no
/// longer exists. The store change that follows the deletion is the only
/// signal, so close the editor once the contact is gone.
private static func observeDeletion(
of contactId: String,
keys: CNKeyDescriptor,
in navController: UINavigationController
) {
storeObserver = NotificationCenter.default.addObserver(
forName: .CNContactStoreDidChange,
object: nil,
queue: .main
) { [weak navController] _ in
let store = CNContactStore()
let contact = try? store.unifiedContact(withIdentifier: contactId, keysToFetch: [keys])
guard contact == nil, let navController else { return }
// Dismiss from the presenter so the delete confirmation, if it is
// still on screen, goes away with the editor.
let presenter = navController.presentingViewController ?? navController
presenter.dismiss(animated: true) {
completeWithResult(nil)
}
}
}

static func completeWithResult(_ value: Any?) {
if let storeObserver {
NotificationCenter.default.removeObserver(storeObserver)
}
storeObserver = nil
pendingResult?(value)
pendingResult = nil
editorDelegate = nil
Expand Down