Replace nested static_for lambdas with compile-time search helper #3600
+134
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
find_in_tuple_of_sequencescompile-time search helper with O(1) template depthstatic_forlambdas inTensorDescriptor::GetTransformAndItsUpperDimensiongenerate_tuplelambda inTensorDescriptor::InitializeElementSizewith pack expansionTensorAdaptorMotivation
The
TensorDescriptorandTensorAdaptorclasses had excessive template instantiation from:static_forloops with lambdas (918applier::operator()instantiations)generate_tuplewith lambdas (78+ instantiations per class)Results (example_grouped_conv_fwd_xdl_fp16)
applierinstantiationsgenerate_tuplelambdasfind_in_tuple_of_sequencesHelperUses O(1) template depth via pack expansion instead of O(N) recursion:
Test Plan
PR Stack
__make_integer_seq