[COMGR][HotSwap] Fix M32 scaled WMMA lowering

[paulzzy]

Jira: ROCM-28594

Summary

Fix regular-scale and Scale16 M32 WMMA lowering for gfx1250 B0-to-A0
HotSwap.

The change:

• splits regular-scale M32 operations into two exact M16 operations and uses
  MATRIX_SCALE_ROW1 for the upper M half;
• replaces in-place Scale16 A/scale mutation with generated bank-zero scratch;
• executes M0 low/high followed by M1 low/high;
• keeps masked A contiguous while allowing four generated scales and the
  gather temporary to use independent dead low-bank VGPRs;
• avoids unnecessary VGPR growth when 13 dead registers are available but are
  not one contiguous interval;
• consumes legacy gfx1250 tensor instructions through canonical LLVM MC
  decoding instead of COMGR raw-byte classifiers;
• exposes stable AMDGPU named operand roles to MC clients and builds the WMMA
  replacement instructions from structured MCOperands rather than parsing
  MCInstPrinter text or mirroring positional operand layouts;
• reuses a locally dead, already-declared SGPR for saturated required tensor
  wrappers when current-text CFG liveness proves it safe;
• rechecks only required tensor trampolines after final pool layout and
  promotes a shifted out-of-range short return into the transactional
  branch-island path merged in PR [comgr][hotswap] Make branch-island allocation transactional #3677.

Review scope

Please review these 12 signed commits in order:

1. 63c2b1e1136e - decode the observed legacy gfx1250 tensor DMA aliases as
   canonical LLVM MC instructions;
2. c72aecf655ac - exact M32 Scale16 lowering;
3. 83608054a2b2 - make the M32 Scale16 lowering bank-safe;
4. 892dafb85d8d - drain XCNT across M32 VGPR bank changes;
5. bd3c63223442 - fix regular/Scale16 M32 splitting, preserve original
   operands, and support fragmented scratch;
6. 452bd2650f3e - remove temporary raw tensor classifiers and consume LLVM
   MC semantics;
7. 4f76e8635f84 - add legacy tensor integration coverage;
8. d1dec3d5f3ff - route required tensor wrappers in saturated kernels;
9. 09e071d5e59e - expose a public AMDGPU named-operand adapter;
10. c2932c4e05d8 - add shared COMGR named-MC helpers;
11. f456866e0d33 - remove printer parsing and build WMMA splits from
    structured operands.
12. 5f80cfed65f6 - restore the canonical LLVM public-header banner.

Commits 2-4 preserve @harsh-amd's original implementation history. The primary
corrective review is commits 5-11.

Root cause

ROCM-28594 tracks 416 parameterized Triton/Gluon
test_amd_wmma_scaled failures. The failing kernels use the B0-only
32x16x128 FP4 WMMA shape:

• 208 cases use E8M0 scale encoding;
• 208 cases use E4M3 scale encoding;
• both groups exercise MXFP4 matrix operands.

A representative reproducer is a non-transposed M=32, N=32, K=128
FP4-by-FP4 kernel with both E8M0 scales enabled. It emits
v_wmma_scale_f32_32x16x128_f4 as intended on B0, but the HotSwapped result
is numerically incorrect on A0.

A0 does not provide the M32 instruction directly. Regular scaled WMMA must be
split into two M16 operations. Scale16 M32 additionally needs a K-subblock
split, producing four exact M16 block-32 WMMAs.

The earlier Scale16 lowering modified matrix A and both scale pairs in place.
That corrupts kernels where only one matrix operand is scaled because later
generated passes still need the original A and scale values. Fully scaled
variants can fail for the same reason when the generated M/K passes reuse
mutated inputs.

Larger parameter combinations also expose a scratch-allocation failure. A
representative 128-VGPR kernel has an eight-register dead low-bank interval
plus five independently dead low-bank registers, but no contiguous
13-register interval. Requiring all scratch to be contiguous grows the kernel
by 13 VGPRs. That changes the metadata note size, prevents a size-preserving
rewrite, and leaves the original B0-only instruction for A0 execution.

The final allocation keeps only the eight masked-A registers contiguous and
allocates the four generated scales and temporary independently. Original A
and scale operands are never modified.

The prior implementation also reconstructed WMMA replacements from printed
assembly text and duplicated backend operand positions. That was fragile for
inline floating-point immediates, modifiers, tied operands, and aliased
source/destination operands. The final implementation queries named operand
roles, transforms MCInsts directly, copies the original MCOperand values,
and emits the result through MCCodeEmitter.

Canonical decoding also exposes required legacy tensor wrappers in kernels
whose declared SGPR footprint is saturated. Those kernels can still have a
register that is dead across the wrapper and its continuation. The fallback
uses current-text CFG liveness to reuse that register without metadata growth.
If final trampoline layout shifts a required short return out of range, the
site is promoted into PR #3677's transactional registerless island path.

Testing

LLVM MC:

• legacy and canonical gfx1250 tensor MC tests pass;
• the exact 12-byte legacy record decodes as canonical
  TENSOR_LOAD_TO_LDS_d4_gfx1250.

Host Release:

• HotswapMCTests: 194/194;
• focused WMMA LIT: 41/41;
• full supported COMGR LIT: 166/166;
• CTest: 32/32.

Clang-19 ASan:

• focused HotswapMCTests: 194/194;
• focused WMMA LIT: 41/41;
• full supported COMGR LIT: 166/166.

A0 numerical validation:

• one-sided Scale16 regression: 1/1 passed with candidate-load proof;
• complete M32 wmma_shape1 family: 208 passed, 3,536 skipped, zero failed;
• pre/post device-holder audits were clean.

The numerical runs preserved 169 unique Triton input HSACOs. Rewriting all
169 with the prior numerically validated candidate and this candidate produced
169/169 byte-identical, idempotent outputs with zero status or hash changes.

20,442-object corpus:

• parent: 20,382 pass / 58 fail / 2 established timeout;
• candidate: 20,392 pass / 48 fail / 2 established timeout;
• status changes: ten previously failing inputs -> pass, zero pass -> fail;
• common outputs: 20,381 unchanged, one expected Scale16 output changed;
• candidate-only outputs: ten;
• all 20,392 emitted outputs passed ELF validation and byte-identical second
  rewrite.

The full host and A0 validation above was completed on the merged-#3677
amd-staging tip used during development. The final refresh onto live
amd-staging (7f7448fc5af9) was conflict-free; all 11 stable patch IDs and
the complete git range-diff are identical, and git diff --check passes.

[Copilot]

Pull request overview

This PR fixes gfx1250 B0→A0 HotSwap correctness for M=32 scaled WMMA by moving the lowering and rewriter pipeline onto structured LLVM MC semantics (named operands + canonical decoding), enabling exact M/K splits without mutating source operands and without unnecessary register growth.

Changes:

• Add canonical decoding support for legacy gfx1250 tensor records and integrate them into existing HotSwap tensor handling (including saturated-SGPR fallback behavior).
• Refactor WMMA split and Scale16 lowering to build replacements from structured MCInst/MCOperand data via named operands and MCCodeEmitter, avoiding printer/text parsing and preserving inline-immediate semantics.
• Add extensive unit + LIT coverage for named-operand resolution, forward-dead VGPR proofs, bank-zero constraints/XCNT drains, scratch fragmentation, overlap fail-closed gates, and final-layout trampoline promotion.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
llvm/test/MC/AMDGPU/gfx1250_asm_vimage_legacy.s	New MC coverage for assembling/disassembling legacy tensor encodings as canonical ops.
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp	Implements public MCNamedOperand→TableGen operand-name mapping.
llvm/lib/Target/AMDGPU/MIMGInstructions.td	Introduces legacy tensor “real” defs with legacy fixed fields and legacy mnemonics.
llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp	Normalizes legacy tensor opcodes to canonical opcodes after decode.
llvm/include/llvm/TargetParser/AMDGPUOperandInfo.h	New public header exposing a stable AMDGPU MC named-operand API.
amd/comgr/test-unit/hotswap/rewriter/HotswapMCTest.cpp	Adds tests for named operand lookup, forward-dead VGPR proofs, and trampoline final-layout promotion.
amd/comgr/test-unit/hotswap/rewriter/CMakeLists.txt	Links AMDGPUUtils for the new named-operand helper.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-split-src2-eq-dst.s	Updates test rationale for structured MCOperand src2 preservation.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-split-neg-lo-k.s	Clarifies default-encoding behavior for packed neg modifiers in split output.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-split-msplit-neg-lo.s	Updates expectations to reflect structured output semantics vs printer ordering.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-split-fp-imm.s	Tightens test to require direct MCOperand copying for FP inline immediates.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-scale16-large-vgpr-count.s	Adjusts disasm checks for reduced VGPR-growth behavior and bank-safe sequencing.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-scale16-32x16.s	New end-to-end fixture for exact M+K split lowering and scratch reuse reporting.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-scale16-32x16-split-scratch.s	New fixture proving fragmented low-bank scratch allocation avoids VGPR bumps.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-scale16-32x16-refuse.s	Reworks fail-closed tests into independent overlap-gated cases.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-scale16-32x16-bank-zero.s	New fixture enforcing bank-zero scale-prefix behavior and XCNT drains across remaps.
amd/comgr/test-lit/hotswap/rewriter/hotswap-wmma-scale-32x16.s	New fixture for regular-scale M32→two exact M16 splits using structured operands.
amd/comgr/test-lit/hotswap/rewriter/hotswap-trampoline-tensor-mask-failclosed.s	Extends tensor fail-closed test to eliminate any remaining scratch SGPR options.
amd/comgr/test-lit/hotswap/rewriter/hotswap-trampoline-tensor-legacy-mc.s	New end-to-end fixture validating legacy tensor MC integration through HotSwap.
amd/comgr/src/hotswap/rewriter/patch-wmma-split.cpp	Replaces printer/text-based WMMA splitting with named-operand/MCInst-based construction and encoding.
amd/comgr/src/hotswap/rewriter/patch-wmma-scale16.cpp	Implements exact M32 regular-scale split, exact M+K Scale16 split, bank-safe scratch reuse, and physical forward-dead proofs.
amd/comgr/src/hotswap/rewriter/patch-trampoline.cpp	Adds locally-dead SGPR reuse fallback for required tensor wrappers and marks them for final-layout recheck.
amd/comgr/src/hotswap/rewriter/llvm.cpp	Adds helpers for parsing single MCInsts, named-operand lookup/copy, and appending encoded instructions.
amd/comgr/src/hotswap/rewriter/internal.h	Declares new MC helpers, forward-dead proof APIs, and required-trampoline final-layout promotion support.
amd/comgr/src/hotswap/rewriter/CMakeLists.txt	Links AMDGPUUtils and updates documentation for named-operand usage.
amd/comgr/src/hotswap/rewriter/b0a0.cpp	Adds final-layout promotion pass for required short trampolines before island allocation.

[paulzzy]

Heads up that I'm planning to rebase on amd-staging after #3614 lands

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[paulzzy]

CI note: Linux::release / Test rocm-examples is currently reproducing an amd-staging gfx942 lane failure rather than a change-specific regression.

• PR attempt 1 and the failed-only attempt 2 ran on different gfx942 runners and both produced the exact same result: 16 identical HIP-Basic tests segfaulted in the same ~1.2-second window (30% tests passed).
• The concurrent merge main into amd-staging workflow failed the same job with the same signature.
• An unrelated PR immediately preceding this one also failed the same 16 tests.
• Linux/Windows builds, code formatting, Linux/Windows COMGR, and Linux/Windows SPIR-V checks pass on 5f80cfed65f6.

Relevant jobs: attempt 1, attempt 2, and concurrent amd-staging merge.

[chinmaydd]

Closing due to inactivity. Please reopen if needed.