[ASan][AMDGPU] Retry HSA resolution after late HIP load - #3827
Draft
sa-faizal wants to merge 1 commit into
Draft
Conversation
sa-faizal
marked this pull request as draft
August 9, 2026 06:30
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASan can initialize before applications that
dlopen()HIP have loaded ROCr. The initialRTLD_NEXTlookups then leave the AMDGPU HSA callback table incomplete.After the real
hsa_init()succeeds, retry the idempotent HSA symbol lookup before registering the shutdown callback. If resolution still fails, reset the registration guard and return instead of calling through a null function pointer.Add a regression that starts ASan first, dlopens
libamdhip64.so.7, and callshipInit.Validation:
clang_rt.asan-dynamic-x86_64rebuilt successfully.hipInit succeeded.hipInit_status 0.clang-format --dry-run --Werrorandgit diff --checkpass.