[Comgr] Resolve symbols through a cached parse and name index - #3841
Draft
chinmaydd wants to merge 1 commit into
Draft
[Comgr] Resolve symbols through a cached parse and name index#3841chinmaydd wants to merge 1 commit into
chinmaydd wants to merge 1 commit into
Conversation
This was referenced Aug 10, 2026
Every amd_comgr_symbol_lookup re-parsed the ELF and linearly scanned all symbols, so m lookups on an n-symbol object cost m parses and m*n comparisons. amd_comgr_iterate_symbols re-parsed too, including when driven internally by amd_comgr_populate_mangled_names. Cache the parsed object file on the DataObject and build a name index once. First occurrence still wins for lookup; iteration order, count and per-callback handle allocation are unchanged. 200000 repeat lookups on shared-v3.so (4 symbols): 129 ms -> 25 ms. Co-authored-by: Cursor <cursoragent@cursor.com>
chinmaydd
force-pushed
the
amd/dev/chdeshpa/comgr-symbol-index
branch
from
August 10, 2026 17:50
b477fa7 to
377a047
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is second in a series of PRs that improves Comgr.
Every
amd_comgr_symbol_lookupre-parsed the ELF and linearly scanned all symbols, so m lookups on an n-symbol object cost m parses and m*n comparisons.amd_comgr_iterate_symbolsre-parsed too, including when driven internally byamd_comgr_populate_mangled_names.Cache the parsed object file on the DataObject and build a name index once. First occurrence still wins for lookup; iteration order, count and per-callback handle allocation are unchanged.
200000 repeat lookups on shared-v3.so (4 symbols): 129 ms -> 25 ms.
[1/3] <- #3840
[2/3] <- you are here
[3/3] <- #3842