[hipcc] Skip llc version probe when llc is not installed - #3867
Draft
Samiii777 wants to merge 1 commit into
Draft
Conversation
hipconfig --full unconditionally runs '<hip_clang_path>/llc --version'. llc is not shipped by the ROCm packages, so the shell emits sh: 1: /opt/rocm/core-7.14/lib/llvm/bin/llc: not found into hipconfig output on every invocation. Check that the binary exists before running it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hipconfig --fullunconditionally executes<hip_clang_path>/llc --version, butllcis not shipped by any ROCm package. On a stock ROCm install the shell error leaks into hipconfig's output on every invocation:Confirmed no ROCm package provides it:
This is noise for interactive users and can confuse scripts that capture hipconfig's stderr. ROCm/hip#287 previously adjusted the
llcpath, but the call site still assumes the binary is present.Fix
Check that
llcexists before invoking it. When present, behaviour is unchanged.Test
Built
hipconfigfrom this branch and verified both paths:llcabsent (stock ROCm 7.14)sh: 1: .../llc: not foundllcpresent (stub onHIP_CLANG_PATH)Remaining
--fulloutput (HIP version, paths, compiler version, cxxflags/ldflags) is byte-identical, and--version/--path/--rocmpath/--compiler/--platform/--runtime/--hipclangpath/-Care unaffected.Environment: ROCm 7.14.0~pre3, gfx1100 (RX 7900 XTX), Ubuntu 26.04.