[Offload] Fix DYLIB command for CMake causing link errors with new offload project - #3878
Closed
agozillon wants to merge 1 commit into
Closed
[Offload] Fix DYLIB command for CMake causing link errors with new offload project#3878agozillon wants to merge 1 commit into
agozillon wants to merge 1 commit into
Conversation
…fload project This will hopefully be fixed upstream soon, I left a comment in the offending PR, so this may be a temporary fix. But at least it allows us to compile it which might allow us to avoid hidden issues while it gets fixed upstream.
ronlieb
requested changes
Aug 13, 2026
ronlieb
left a comment
ronlieb
left a comment
Collaborator
There was a problem hiding this comment.
wait to land , until after merge
Collaborator
|
folded into #3889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will hopefully be fixed upstream soon, I left a comment in the offending PR, so this may be a temporary fix. But at least it allows us to compile it with build_aomp.sh in the meantime which might allow us to avoid hidden issues while it gets fixed upstream.