Remove legacy ROCm OpenMP transform tests - #3884
Open
lfmeadow wants to merge 1 commit into
Open
Conversation
…nes, spmdization, spmdization_guarding) These tests are upstreamed in a different, newer format; deleting the ROCm copies avoids merge conflicts. One test shows only cosmetic differences with the srock compiler. Co-authored-by: Cursor <cursoragent@cursor.com>
ronlieb
self-requested a review
August 13, 2026 11:20
ronlieb
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nDelete ROCm copies of long-removed deviceRTL tests so upstream tests merge cleanly. The device runtime code was removed; only these three lit tests remained in ROCm.\n\n## Rationale\n- These tests are present upstream in a newer format.\n- Keeping ROCm copies causes merge conflicts and duplicated tests.\n- One test, , fails with srock but differences are cosmetic (addrspace/select form and attribute renumbering) and do not change runtime semantics.\n\n## Test plan\n- Ran BC��5��b 0$JY�f���O�Q�L�! ���!����#�A��I��29��� %������b��E�B��B$�2�8��K
2��Hp�!#D����A��d���� CF� ��2���*(*�1|�\� �ȉ 2"H� bF!+$��!%$���' ���
�d\ $a� ���!L��ޜNN�}�������b�3������f��=�C8�ÌB��yx�s�q ��������3 B����Ρ�f0�=�C8�����=�C=��=�x�tp�{��yH�pp�zp�vx�p ���������0�n0�����P�3����!��!��a�f0�;��;�C9��<��<��;���v�{h�7h�rh�7��p��p�v(�v��vx�w��_��q��r��y��,����������0�bȡ����̡�����a��!�ā��a�C9�C9�C9�C9��8�C8��;��/��<��;��;�� �i�pX�rp�th�x�t��t����S����P�����@�� ��P�3 (�����A��!�܁����������f�Q8�C:��;�P$v�{h�7�wx�x�QL����P�3�j��a��!����~������!��a�T��8��;�C=�C9��<�C;��;�Ì��y��w��t��z(�r��\�������P��0#��A����������fH�;��=�����8�C9��<��9��;��<�H�q��v
�q��qX����������� ��0�� ��P�n���0��0��������P��0#��a�������!��!��!��!��!�f �;�C=��9��9�X�pp�wx�z��zH�wp���!�r(�w��zXp�C=��8�C9�Â��ơ
�A�����!��!�����4�
��P�� ��@�� ��P������y(�p�vx�q��z(�rXp��8��;��=���k��!����� ��a�� �����a���a����������<��;��;��=��<�C8���q �2��"�] ����14.0.0+ from the srock toolchain locally; two tests passed, one had only cosmetic mismatches.\n- CI: rely on upstream tests after merge.\n\nPlease review: @rlieberm (Ron)\n
Made with Cursor