View: Add time-range selection indicators across timeline, tables, and overview - #995
Merged
Merged
Conversation
…d overview Make it explicit which results depend on the active time-range selection: - Pills: tint per-track analysis stat pills (counter min/max/avg/stddev, queue utilization) blue while a selection is active; neutral otherwise. - Tables: add a scope indicator to the events and top-events tables - accent "Limited to time-range selection" (with span tooltip) vs dim "Full trace". - Timeline: dim tracks outside the selection (spotlight), and repaint the out-of-selection slice of partially-included flame events at full brightness so they still read as included in the results. - Overview histogram: grey bars outside the current view (minimap) with straddling bars split into in/out slices, draw start/end selection markers showing where the selection sits in the full trace, and align the overview's time axis with the timeline graph when fully zoomed out. Co-authored-by: Cursor <cursoragent@cursor.com>
dhingora-amd
requested review from
Sajeeth-Wimalasuriyan,
amokiche-amd,
drchen-amd and
tomk-amd
as code owners
August 12, 2026 16:03
drchen-amd
reviewed
Aug 12, 2026
drchen-amd
left a comment
drchen-amd
left a comment
Member
There was a problem hiding this comment.
I don't like how it makes the event names hard to read.
tomk-amd
reviewed
Aug 12, 2026
Remove the main-graph range-selection dimming scrim and the foreground repaint of partially-selected flame events. Grey overview histogram bars outside the active selection so the selected span stays highlighted. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace Pill's bespoke m_range_affected bool with an optional text-color override (SetTextColor) so any state can retint the pill, per review. Callers pass kAccent while a time-range selection is active; behavior is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
drchen-amd
approved these changes
Aug 18, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Draw a |--<duration>--| bracket across the time-range selection in the overview histogram's tick-mark row; when the span is too narrow, place the duration label beside the caps on whichever side has room. Co-authored-by: Cursor <cursoragent@cursor.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tomk-amd
approved these changes
Aug 21, 2026
tomk-amd
left a comment
tomk-amd
left a comment
Collaborator
There was a problem hiding this comment.
Please fix the shadow var issue mentioned by code ql, the it is good to go.
Collaborator
|
We will need to implement an indicator for Track Details as well (separate PR): 
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Reconcile the overview histogram with main's RenderHeader/RenderHistogram split: pass graph_origin_x into RenderHistogram(float) so the greyscale, selection markers, and duration bracket resolve it in scope. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a time-range selection is active, several views silently recompute or filter
their results, but nothing signals that on screen. This PR makes it explicit which
data depends on the current selection, and makes the selected region easy to spot.
Technical Details
utilization) tint blue while a selection is active, neutral otherwise
(
Pill::SetRangeAffected).— accent "Limited to time-range selection" (with a span tooltip) vs dim
"Full trace".
events that only partially fall inside are repainted at full brightness above the
scrim so they still read as included in the results.
bars straddling a view edge split into in/out slices; start/end markers show where
the selection sits in the full trace; the overview's time axis is aligned with the
timeline graph when fully zoomed out.