refactor(hipblaslt): convert gfx950 C library logic to dict format - #10385
Open
dsaffars wants to merge 1 commit into
Open
refactor(hipblaslt): convert gfx950 C library logic to dict format#10385dsaffars wants to merge 1 commit into
dsaffars wants to merge 1 commit into
Conversation
Convert 8 gfx950 C library logic YAML files from list to dict format. # Batch: C # Per-file lines (before -> after): gfx950/GridBased/gfx950_Cijk_Ailk_Bjlk_C_B_UserArgs.yaml: 332 -> 420 gfx950/GridBased/gfx950_Cijk_Ailk_Bjlk_C_C_B_UserArgs.yaml: 332 -> 420 gfx950/GridBased/gfx950_Cijk_Ailk_Bjlk_C_Z_B_UserArgs.yaml: 812 -> 732 gfx950/GridBased/gfx950_Cijk_Ailk_Bljk_C_B_UserArgs.yaml: 810 -> 730 gfx950/GridBased/gfx950_Cijk_Alik_Bjlk_C_B_UserArgs.yaml: 810 -> 730 gfx950/GridBased/gfx950_Cijk_Alik_Bjlk_C_C_B_UserArgs.yaml: 810 -> 730 gfx950/GridBased/gfx950_Cijk_Alik_Bjlk_C_Z_B_UserArgs.yaml: 573 -> 577 gfx950/GridBased/gfx950_Cijk_Alik_Bljk_C_B_UserArgs.yaml: 810 -> 730 Total: 5289 -> 5069 lines across 8 files.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID: AIHPBLAS-4216
Convert 8 gfx950 C library logic YAML files from list to dict format.
Motivation
TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (
ArchitectureName,CUCount,ProblemType,Solutions, etc.) and is the formatTensileCreateLibrarynow emits by default.The C datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.
Technical Details
This PR converts 8 gfx950 C library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/GridBased/Format changes (no semantic changes intended):
MinimumRequiredVersion,ScheduleName,ArchitectureName,CUCount,DeviceNames,ProblemType, …).ProblemTypefields are nested under aProblemType:mapping instead of inline list items.Solutions:dict keyed by solution name.True/False→true/false).Scope summary:
This PR is YAML-only ; no runtime, generator, or test-code changes. It builds on
users/dsaffars/Lib_conv_gfx950_Din the stacked PR series.Test Plan
For each of the 8 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as
TensileCreateLibrary):Test Result
For all 8/8 C files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 8 C logic files (GridBased).
Line count: Total YAML size reduced from 5,289 to 5,069 lines (~4% reduction) with no intended change to kernel selection behavior.