refactor(hipblaslt): convert gfx950 F4 library logic to dict format - #10390
refactor(hipblaslt): convert gfx950 F4 library logic to dict format#10390dsaffars wants to merge 1 commit into
Conversation
Convert 9 gfx950 F4 library logic YAML files from list to dict format. # Batch: F4 # Per-file lines (before -> after): gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12484 gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12484 gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12484 Total: 150678 -> 112668 lines across 9 files.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
|
Heads-up from the rocm-libraries gardener rotation: #10016 The overlap is exact — #10016 updated 3 of the 9 files this PR touches:
#10016 added 23 new MTs to those three One thing to be aware of before you push: GitHub Actions is in an active major outage right now |
JIRA ID: AIHPBLAS-4216
Convert 9 gfx950 F4 library logic YAML files from list to dict format.
Motivation
TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (
ArchitectureName,CUCount,ProblemType,Solutions, etc.) and is the formatTensileCreateLibrarynow emits by default.The F4 datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.
Technical Details
This PR converts 9 gfx950 F4 library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/Format changes (no semantic changes intended):
MinimumRequiredVersion,ScheduleName,ArchitectureName,CUCount,DeviceNames,ProblemType, …).ProblemTypefields are nested under aProblemType:mapping instead of inline list items.Solutions:dict keyed by solution name.True/False→true/false).Scope summary:
This PR is YAML-only; no runtime, generator, or test-code changes. It builds on
users/dsaffars/Lib_conv_gfx950_miscin the stacked PR series.Test Plan
For each of the 9 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as
TensileCreateLibrary):Test Result
For all 9/9 F4 files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 9 F4 logic files (Origami, Origami/Origami_nta4, Origami/Origami_ntb4).
Line count: Total YAML size reduced from 150,678 to 112,668 lines (~25% reduction) with no intended change to kernel selection behavior.