Skip to content

refactor(hipblaslt): convert gfx950 F8SS library logic to dict format - #10397

Open
dsaffars wants to merge 1 commit into
users/dsaffars/Lib_conv_gfx950_F8BSfrom
users/dsaffars/Lib_conv_gfx950_F8SS
Open

refactor(hipblaslt): convert gfx950 F8SS library logic to dict format#10397
dsaffars wants to merge 1 commit into
users/dsaffars/Lib_conv_gfx950_F8BSfrom
users/dsaffars/Lib_conv_gfx950_F8SS

Conversation

@dsaffars

@dsaffars dsaffars commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

JIRA ID: AIHPBLAS-4216

Convert 27 gfx950 F8SS library logic YAML files from list to dict format.

Motivation

TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (ArchitectureName, CUCount, ProblemType, Solutions, etc.) and is the format TensileCreateLibrary now emits by default.
The F8SS datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.

Technical Details

This PR converts 27 gfx950 F8SS library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/
Format changes (no semantic changes intended):

  • Root metadata moves from positional list entries to named keys (MinimumRequiredVersion, ScheduleName, ArchitectureName, CUCount, DeviceNames, ProblemType, …).
  • ProblemType fields are nested under a ProblemType: mapping instead of inline list items.
  • Solution entries move from list-of-flow-mappings to a Solutions: dict keyed by solution name.
  • Boolean literals are normalized (True/Falsetrue/false).
    Scope summary:
Metric Before After
Files 27 27
Total lines 551,826 396,363

This PR is YAML-only; no runtime, generator, or test-code changes. It builds on users/dsaffars/Lib_conv_gfx950_F8BS in the stacked PR series.

Test Plan

For each of the 27 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as TensileCreateLibrary):

Test Result

For all 27/27 F8SS files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 27 F8SS logic files (Origami, Origami/Origami_nta4, Origami/Origami_ntb4).
Line count: Total YAML size reduced from 551,826 to 396,363 lines (~28% reduction) with no intended change to kernel selection behavior.

Convert 27 gfx950 F8SS library logic YAML files from list
to dict format.

# Batch: F8SS
# Per-file lines (before -> after):
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bjlk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bjlk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bljk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bljk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bjlk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bjlk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8SS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 19448 -> 13773
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bjlk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bjlk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bljk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bljk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bjlk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bjlk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8SS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 19448 -> 13773
  gfx950/Origami/gfx950_Cijk_Ailk_Bjlk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8074
  gfx950/Origami/gfx950_Cijk_Ailk_Bjlk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8074
  gfx950/Origami/gfx950_Cijk_Ailk_Bljk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14274
  gfx950/Origami/gfx950_Cijk_Ailk_Bljk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14274
  gfx950/Origami/gfx950_Cijk_Alik_Bjlk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14269
  gfx950/Origami/gfx950_Cijk_Alik_Bjlk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14269
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22323
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22323
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8SS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 19448 -> 13721
Total: 551826 -> 396363 lines across 27 files.
@dsaffars
dsaffars requested a review from a team as a code owner August 5, 2026 11:09
@therock-pr-bot

therock-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant