Skip to content

[rocpd] Schema Updates - #347

Draft
systems-assistant[bot] wants to merge 32 commits into
developfrom
import/develop/ROCm_rocprofiler-sdk/jomadsen_rocprofiler-sdk-rocpd-updates
Draft

[rocpd] Schema Updates#347
systems-assistant[bot] wants to merge 32 commits into
developfrom
import/develop/ROCm_rocprofiler-sdk/jomadsen_rocprofiler-sdk-rocpd-updates

Conversation

@systems-assistant

@systems-assistant systems-assistant Bot commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Continuous Integration

Technical details

Added/updated tests?

  • Yes
  • No, Does not apply to this PR.

Updated CHANGELOG?

  • Yes
  • No, Does not apply to this PR.

Added/Updated documentation?

  • Yes
  • No, Does not apply to this PR.

🔁 Imported from ROCm/rocprofiler-sdk#118
🧑‍💻 Originally authored by @rocm-devops

@jrmadsen
jrmadsen force-pushed the import/develop/ROCm_rocprofiler-sdk/jomadsen_rocprofiler-sdk-rocpd-updates branch from c303613 to 7ddd5da Compare August 14, 2025 16:21
@jrmadsen
jrmadsen force-pushed the import/develop/ROCm_rocprofiler-sdk/jomadsen_rocprofiler-sdk-rocpd-updates branch from 7ddd5da to c235cff Compare August 14, 2025 21:31
@jrmadsen
jrmadsen force-pushed the import/develop/ROCm_rocprofiler-sdk/jomadsen_rocprofiler-sdk-rocpd-updates branch from c235cff to f5335e5 Compare August 22, 2025 18:05
@jrmadsen
jrmadsen requested a review from bgopesh as a code owner August 22, 2025 18:05
bwelton
bwelton reviewed Aug 26, 2025
View reviewed changes

@bwelton bwelton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have been on the original PR, but can you add some context about why this is being changed and what the effect of the change is?

yhuiYH
yhuiYH reviewed Sep 17, 2025
View reviewed changes
Comment thread projects/rocprofiler-sdk/source/lib/python/rocpd/merge.py
Comment on lines +149 to +151
for name in tbls:
log(f"Inserting rows into {name} from {alias}.{name}")
conn.execute(f'INSERT INTO "{name}" SELECT * FROM {alias}."{name}"')

@yhuiYH yhuiYH Sep 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for name in tbls:
log(f"Inserting rows into {name} from {alias}.{name}")
conn.execute(f'INSERT INTO "{name}" SELECT * FROM {alias}."{name}"')
for name in tbls:
log(f"Inserting rows into {name} from {alias}.{name}")
rows = conn.execute(f'SELECT * FROM {alias}."{name}"').fetchall()
if rows:
col_count = len(rows[0])
placeholders = ", ".join(["?"] * col_count)
conn.executemany(
f'INSERT INTO "{name}" VALUES ({placeholders})',
rows
)

Looking at merge.py, @bgopesh suggested I change this to a batch operation in my PR. Doing that in your implementation will halve the merge time! I'm looking at ways of incorporating your merge.py with the merge.py that the Silo team wrote in my PR. But this is a good change to pickup.

Comment thread projects/rocprofiler-sdk/source/lib/python/rocpd/merge.py
Comment on lines +229 to +233
# Optional: enforce integrity
try:
conn.execute("PRAGMA quick_check;")
except sqlite3.DatabaseError as e:
log(f"SQLite3 quick_check reported an issue: {e}")

@yhuiYH yhuiYH Sep 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This integrity check (I see you have it marked as optional here in the comments) will add a 66%-175% time hit to merge time. It may be better to skip it, or have it as a user-opt-in check (but what user will really want to turn this on?).
ie, merging 2 13MB DBs, merge time goes from 3.67 seconds to 1.33 seconds when we skip this check.
merging 16 13MB DBs, merge time goes from 37.03 seconds to 22.23 second when we skip this check.

@jrmadsen
jrmadsen force-pushed the import/develop/ROCm_rocprofiler-sdk/jomadsen_rocprofiler-sdk-rocpd-updates branch 2 times, most recently from be09959 to f1b9797 Compare September 22, 2025 18:41
@jrmadsen jrmadsen added the WIP label Sep 30, 2025
ammallya pushed a commit that referenced this pull request Jan 21, 2026
@drprajap @abouteiller
Add IBGDA backend flag to enable bitcode generation (#347)
fbe5730 
* Change to enable ibgda bitcode compilation

* Apply suggestion from @abouteiller

---------

Co-authored-by: Aurelien Bouteiller <aurelien.bouteiller@amd.com>
ammallya pushed a commit that referenced this pull request Jan 21, 2026
@drprajap
Add IBGDA backend flag to enable bitcode generation (#347)
b9c172d 
* Change to enable ibgda bitcode compilation

* Apply suggestion from @abouteiller

---------

Co-authored-by: Aurelien Bouteiller <aurelien.bouteiller@amd.com>

[ROCm/rocshmem commit: fbe5730]
@jayhawk-commits
jayhawk-commits requested review from a team as code owners February 26, 2026 21:20
This was referenced Apr 14, 2026
Closed
Closed
Closed
@anujshuk-amd anujshuk-amd mentioned this pull request Apr 23, 2026
Closed
5 tasks
@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label May 14, 2026
@yhuiYH

yhuiYH commented May 14, 2026

Copy link
Copy Markdown
Contributor

Do NOT close yet, we are still referencing this PR to move the necessary pieces into develop.

@github-actions github-actions Bot removed the Stale PR has no activity for 25+ days label May 15, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Jun 9, 2026
@yhuiYH

yhuiYH commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

BUMP, still referencing this PR for schema updates.

@github-actions github-actions Bot removed the Stale PR has no activity for 25+ days label Jun 11, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Jul 7, 2026
@yhuiYH

yhuiYH commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

BUMP, do not close yet

@github-actions github-actions Bot removed the Stale PR has no activity for 25+ days label Jul 10, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed due to inactivity (30 days with no updates).

If you'd like to continue working on this, feel free to reopen the PR or create a new one.

@github-actions github-actions Bot closed this Aug 11, 2026
@yhuiYH yhuiYH reopened this Aug 11, 2026
@yhuiYH
yhuiYH marked this pull request as draft August 11, 2026 00:40
@therock-pr-bot

therock-pr-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

🤖 Bump PR detected (author @systems-assistant[bot]). All policy checks are auto-approved for automated dependency bumps.

@github-actions github-actions Bot removed the Stale PR has no activity for 25+ days label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwelton bwelton bwelton left review comments
@yhuiYH yhuiYH yhuiYH left review comments
@SrirakshaNag SrirakshaNag Awaiting requested review from SrirakshaNag
@jrmadsen jrmadsen Awaiting requested review from jrmadsen
@ammarwa ammarwa Awaiting requested review from ammarwa
@t-tye t-tye Awaiting requested review from t-tye
@dmitrii-galantsev dmitrii-galantsev Awaiting requested review from dmitrii-galantsev
@oliveiradan oliveiradan Awaiting requested review from oliveiradan
@bgopesh bgopesh Awaiting requested review from bgopesh

At least 1 approving review is required to merge this pull request.

Assignees

@jrmadsen jrmadsen

@yhuiYH yhuiYH

Labels

imported pr organization: ROCm project: rocprofiler-sdk WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhuiYH @bwelton @jrmadsen @jayhawk-commits