Skip to content

[imxrt1180_evk] BSP: add configurations to support PR11529 LPADC&hype… - #8

Merged
Rbb666 merged 1 commit into
RT-Thread-packages:masterfrom
Jason0204:imx1180_evk_lpadc_flexspi_dma
Jul 7, 2026
Merged

[imxrt1180_evk] BSP: add configurations to support PR11529 LPADC&hype…#8
Rbb666 merged 1 commit into
RT-Thread-packages:masterfrom
Jason0204:imx1180_evk_lpadc_flexspi_dma

Conversation

@Jason0204

@Jason0204 Jason0204 commented Jul 6, 2026

Copy link
Copy Markdown

modify configuration to support LPADC and FlexSPI with DMA.

Summary by CodeRabbit

  • New Features
    • Expanded hardware support by automatically including additional drivers for MIMXRT1189 when the relevant options are enabled.
    • Improved compatibility for configurations using FlexSPI DMA and LPADC functionality.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

MIMXRT1180/SConscript is updated to conditionally include two additional MIMXRT1189 driver source files: fsl_flexspi_edma.c under the existing DMA-related conditional, and fsl_lpadc.c under the BSP_USING_LPADC flag.

Changes

Build Script Driver Source Additions

Layer / File(s) Summary
Add FlexSPI eDMA and LPADC driver sources
MIMXRT1180/SConscript
Appends fsl_flexspi_edma.c to the DMA-related source block and fsl_lpadc.c when BSP_USING_LPADC is enabled.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: Rbb666

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding BSP configurations for LPADC and FlexSPI/DMA support in imxrt1180_evk.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
MIMXRT1180/SConscript (1)

26-30: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Gate fsl_flexspi_edma.c on BSP_USING_FLEXSPI tooMIMXRT1180/SConscript:26-30. fsl_flexspi_edma.c calls FLEXSPI_GetInstance, FLEXSPI_GetTxFifoAddress, FLEXSPI_EnableTxDMA, and FLEXSPI_CheckAndClearError, which come from fsl_flexspi.c; with only BSP_USING_DMA set, the build can miss those symbols.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@MIMXRT1180/SConscript` around lines 26 - 30, Gate the addition of
fsl_flexspi_edma.c in the MIMXRT1180/SConscript source list on BSP_USING_FLEXSPI
as well as BSP_USING_DMA. Update the conditional around the DMA driver block so
that fsl_flexspi_edma.c is only appended when FlexSPI support is enabled, while
leaving the other DMA-driven sources unchanged. Use the existing GetDepend check
and the fsl_flexspi_edma.c entry as the location to make the guard more
specific.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@MIMXRT1180/SConscript`:
- Around line 26-30: Gate the addition of fsl_flexspi_edma.c in the
MIMXRT1180/SConscript source list on BSP_USING_FLEXSPI as well as BSP_USING_DMA.
Update the conditional around the DMA driver block so that fsl_flexspi_edma.c is
only appended when FlexSPI support is enabled, while leaving the other
DMA-driven sources unchanged. Use the existing GetDepend check and the
fsl_flexspi_edma.c entry as the location to make the guard more specific.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7cad7a7-4d0c-4fe9-ab47-dd60577db8c6

📥 Commits

Reviewing files that changed from the base of the PR and between 8b90dd5 and 52a11c3.

📒 Files selected for processing (1)
  • MIMXRT1180/SConscript

@Rbb666
Rbb666 merged commit 63e4832 into RT-Thread-packages:master Jul 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants