[imxrt1180_evk] BSP: add configurations to support PR11529 LPADC&hype… - #8
Conversation
WalkthroughMIMXRT1180/SConscript is updated to conditionally include two additional MIMXRT1189 driver source files: fsl_flexspi_edma.c under the existing DMA-related conditional, and fsl_lpadc.c under the BSP_USING_LPADC flag. ChangesBuild Script Driver Source Additions
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
MIMXRT1180/SConscript (1)
26-30: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winGate
fsl_flexspi_edma.conBSP_USING_FLEXSPItoo —MIMXRT1180/SConscript:26-30.fsl_flexspi_edma.ccallsFLEXSPI_GetInstance,FLEXSPI_GetTxFifoAddress,FLEXSPI_EnableTxDMA, andFLEXSPI_CheckAndClearError, which come fromfsl_flexspi.c; with onlyBSP_USING_DMAset, the build can miss those symbols.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@MIMXRT1180/SConscript` around lines 26 - 30, Gate the addition of fsl_flexspi_edma.c in the MIMXRT1180/SConscript source list on BSP_USING_FLEXSPI as well as BSP_USING_DMA. Update the conditional around the DMA driver block so that fsl_flexspi_edma.c is only appended when FlexSPI support is enabled, while leaving the other DMA-driven sources unchanged. Use the existing GetDepend check and the fsl_flexspi_edma.c entry as the location to make the guard more specific.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@MIMXRT1180/SConscript`:
- Around line 26-30: Gate the addition of fsl_flexspi_edma.c in the
MIMXRT1180/SConscript source list on BSP_USING_FLEXSPI as well as BSP_USING_DMA.
Update the conditional around the DMA driver block so that fsl_flexspi_edma.c is
only appended when FlexSPI support is enabled, while leaving the other
DMA-driven sources unchanged. Use the existing GetDepend check and the
fsl_flexspi_edma.c entry as the location to make the guard more specific.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f7cad7a7-4d0c-4fe9-ab47-dd60577db8c6
📒 Files selected for processing (1)
MIMXRT1180/SConscript
modify configuration to support LPADC and FlexSPI with DMA.
Summary by CodeRabbit