Skip to content

fix: bsp/stm32: drv_qspi: zero-initialize qspi_device struct - #11656

Closed
jiaoxy0 wants to merge 1 commit into
RT-Thread:masterfrom
jiaoxy0:fix-drv-qspi-zeroinit
Closed

fix: bsp/stm32: drv_qspi: zero-initialize qspi_device struct#11656
jiaoxy0 wants to merge 1 commit into
RT-Thread:masterfrom
jiaoxy0:fix-drv-qspi-zeroinit

Conversation

@jiaoxy0

@jiaoxy0 jiaoxy0 commented Jul 23, 2026

Copy link
Copy Markdown

rt_hw_qspi_device_attach() allocates qspi_device via rt_malloc() but does not zero it, leaving uninitialized fields with random values. This can cause undefined behavior when fields like enter_qspi_mode are checked before being explicitly set.

Fix: Add rt_memset() right after allocation and error check.

rt_hw_qspi_device_attach() allocates qspi_device via rt_malloc()
but does not zero it, leaving uninitialized fields with random
values. Add rt_memset() to prevent undefined behavior.

Signed-off-by: jiaoxy0 <jiaoxiaoyu0@163.com>
@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:fix-drv-qspi-zeroinit
  • 设置PR number为 \ Set the PR number to:11656
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 fix-drv-qspi-zeroinit 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix-drv-qspi-zeroinit branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: STM32 BSP related with ST/STM32 BSP labels Jul 23, 2026
@github-actions

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_qspi.c

📊 Current Review Status (Last Updated: 2026-07-23 23:52 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@wdfk-prog

Copy link
Copy Markdown
Contributor
  • 看着不是很有必要的样子
  • 如果要做使用alloc在分配时直接清零更好
  • 而且要修改就对stm32的驱动都进行扫描都去修改

@jiaoxy0

jiaoxy0 commented Jul 24, 2026

Copy link
Copy Markdown
Author
  • 看着不是很有必要的样子
  • 如果要做使用alloc在分配时直接清零更好
  • 而且要修改就对stm32的驱动都进行扫描都去修改
  • 在MCU不掉电软重启的情况下,会出bug,因为这种情况下那块内存中的初始化标志没被清零,会导致软重启后误判已经初始化,我在实际使用过程中遇到了这个bug
  • 我按照您后两条建议重新修改一下

@jiaoxy0 jiaoxy0 closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants