Use __version__ instead of version() in python #922
Open
axel-grc wants to merge 2 commits intoRTKConsortium:mainfrom
Open
Use __version__ instead of version() in python #922axel-grc wants to merge 2 commits intoRTKConsortium:mainfrom
axel-grc wants to merge 2 commits intoRTKConsortium:mainfrom
Conversation
Collaborator
|
That does not seem to work, I installed a generated package in a new conda env and get |
Collaborator
Author
Yes, I forgot to change how the applications handle the version |
Collaborator
|
Not there yet |
itk.RTK.__version__ is now used to get the version instead of itk.RTK.version()
SimonRit
approved these changes
Mar 30, 2026
Collaborator
|
Thanks, works on my linux box. Can you test on Windows before merging please? |
Collaborator
|
Missing note in the v3 backward incompatibilities doc file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.