-
Notifications
You must be signed in to change notification settings - Fork 287
Modules rewrite #4570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wayland
wants to merge
14
commits into
Raku:main
Choose a base branch
from
wayland:modules-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Modules rewrite #4570
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
83ef11a
Final doc changes
wayland 231f083
Ignoring a couple more items
wayland 77062f3
Changes:
wayland 908d61f
Removed :err because it was causing hangs for me in the test process.…
wayland a4cd652
Merge branch 'Raku:main' into modules-rewrite
wayland e7d9e6d
Requested changes to Makefile and curl call
wayland 6e41bbd
Merge branch 'Raku:main' into modules-rewrite
wayland b1b36f0
Added myself to CREDITS
wayland 860010f
Adjusted paragraph in line with ugexe's recommendations
wayland 0d26977
Added one more line from the old doco that I spotted
wayland 9fec3bb
Removed deprecated code
wayland b8acf22
Edited according to "make xtest"
wayland 60e86f5
Regularised subkind
wayland ca92f0d
As per comments from @ugexe, I have:
wayland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -332,6 +332,9 @@ E: [email protected] | |
| N: Tadeusz Sośnierz | ||
| E: [email protected] | ||
|
|
||
| N: Tim Nelson | ||
| E: [email protected] | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. YAY! |
||
| N: Tim Smith | ||
| E: [email protected] | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,34 @@ | ||
| .PHONY: test xtest push help | ||
| .PHONY: test xtest push help test-mine xtest-mine | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn’t be any changes to this file |
||
|
|
||
| # Common tests - also run by CI | ||
| test test-mine: testlist := t | ||
| # Extended tests - should be run by authors before committing | ||
| xtest xtest-mine: testlist := t xt | ||
|
|
||
| test-mine xtest-mine: TEST_FILES := $(shell git ls-files --modified) | ||
| export TEST_FILES | ||
|
|
||
| help: | ||
| @echo "Usage: make [test|xtest|push]" | ||
| @echo "" | ||
| @echo "Options:" | ||
| @echo " test: run the basic test suite" | ||
| @echo " xtest: run all tests" | ||
| @echo " push: run the basic test suite and git push" | ||
| @echo " test: run the basic test suite" | ||
| @echo " xtest: run all tests" | ||
| @echo " test-mine: run the basic test suite on files with changes" | ||
| @echo "xtest-mine: run all tests on files with changes" | ||
| @echo " push: run the basic test suite and git push" | ||
| @echo " prep: install the prerequisites for running the tests" | ||
|
|
||
| # Common tests - also run by CI | ||
| test: | ||
| if [ "${TEST_JOBS}" != "" ]; then prove --ext=rakutest -j ${TEST_JOBS} -e raku t; else prove --ext=rakutest -e raku t; fi | ||
|
|
||
| # Extended tests - should be run by authors before committing | ||
| xtest: | ||
| if [ "${TEST_JOBS}" != "" ]; then prove --ext=rakutest -j ${TEST_JOBS} -e raku t xt; else prove --ext=rakutest -e raku t xt; fi | ||
| # Actually run the tests | ||
| test xtest test-mine xtest-mine: | ||
| ifeq ("${TEST_JOBS}", "") | ||
| RAKULIB=. prove --ext=rakutest -e raku $(testlist) | ||
| else | ||
| RAKULIB=. prove --ext=rakutest -j ${TEST_JOBS} -e raku $(testlist) | ||
| endif | ||
|
|
||
| push: test | ||
| git pull --rebase && git push | ||
|
|
||
| prep: | ||
| zef install --deps-only --exclude="dot" --/test . | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t need any changes to this file, please remove.