feat: Added a feature guard for raw message fallback#203
Open
jCabala wants to merge 1 commit into
Open
Conversation
scaraven
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature-guard the raw-byte challenge() fallback behind raw-message-fallback so production builds reject malformed/non-PallasMessage inputs (previously silently signed as Testnet/legacy) while tests keep the permissive path.
We couldn't use #[cfg(test)] because the tests needing the fallback live in other crates that compile mina-tx as a normal (non-test) dependency, so #[cfg(test)] would be inactive there. The feature is enabled only via dev-dependency edges, keeping it off in the real binary.
Ideally we remove this feature guard in the future, but that requires fixing many tests. I added an issue for this - #202