Frost client integration tests for dkg#75
Conversation
edwin1729
force-pushed
the
frost-client-integration-tests
branch
2 times, most recently
from
539d1b0 to
b2b04f0
Compare
|
If you want to enable all the verbose message coming from the subprocesses in the terminal, this can be done easily by uncommenting the indicated lines (search "control verbosity") This PR completes half of #59 |
scaraven
left a comment
scaraven
left a comment
There was a problem hiding this comment.
Some small minor changes, which can be implemented in later PRs. However, the integration test should all go under a tests/ folder and marked as a test (with #[test]) so that CI automatically runs it.
edwin1729
force-pushed
the
frost-client-integration-tests
branch
from
b2b04f0 to
36dac57
Compare
|
All comments addressed |
|
Actually nevermind ci still won't work |
edwin1729
force-pushed
the
frost-client-integration-tests
branch
7 times, most recently
from
8159545 to
dcd6780
Compare
edwin1729
force-pushed
the
frost-client-integration-tests
branch
from
dcd6780 to
ac3308c
Compare
| Ok(()) | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
Could you add a small comment either here or at the beginning of the file explaining what the tests do. Otherwise looking good!
There was a problem hiding this comment.
Good point I have no comments, will add in the next pr
3 participants
The test spawns subprocesses and works and extracts outputs using regex matching. All outputs are are stored in
frost-client/tests/assetsand deleted and regenerated for each test. The test is parametric overthreshold(T) andmax-signers(N). There is some dodginess in the fact that a sleep is used so that the dkg coordinator properly starts before a dkg participant can start.