fix(greader): keep the trailing slash when editing an account server URL - #1317
Open
shajz wants to merge 1 commit into
Open
fix(greader): keep the trailing slash when editing an account server URL#1317shajz wants to merge 1 commit into
shajz wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
shajz
marked this pull request as ready for review
August 12, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AddGoogleReaderAccountDialogappends a trailing slash to the server URL, but the edit dialog inGoogleReaderConnectionstores the value as typed. SinceGoogleReaderAPIconcatenates without a separator —.url("${serverUrl}accounts/ClientLogin")— editing an existing account's URL tohttps://example.org/api/greader.phpproduces a request tohttps://example.org/api/greader.phpaccounts/ClientLogin, and sync fails with aGoogleReaderAPIExceptioncarrying the server's raw 404 page.The same one-liner is missing in
FreshRSSConnection, whose add dialog also appends the slash.Repro
This is #837, closed at the time as "seems fixed" but still reproducible on
main.Fix
Normalize on save in both connection screens, the way the add dialogs already do — same shape as #357, which fixed the equivalent Fever bug in both the add and the edit path.