Feat/cs/digital touch render - #768
Merged
Merged
Conversation
ReagentX
commented
Jun 7, 2026
Owner
- Fully implement Digital Touch Support #344
- Investigation and reverse-engineering by @trymoose
Owner
Author
Owner
Author
There was a problem hiding this comment.
Pull request overview
This PR fully implements Digital Touch support (issue #344) by adding a complete Digital Touch parser/renderer to imessage-database and wiring it into both the TXT and HTML exporters, replacing the prior “debug dump” placeholder templates.
Changes:
- Introduces a structured
DigitalTouchMessageAPI that parses Digital Touch protobuf payloads and renders either text summaries or static SVGs (including media messages with image/video handling). - Updates TXT and HTML exporters to use
DigitalTouchMessagerendering, adds/updates tests, and removes the old Digital Touch debug templates/view-models. - Extends error plumbing to surface Digital Touch parsing errors with detail via
PlistParseError.
Reviewed changes
Copilot reviewed 27 out of 32 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates supported macOS build string/version reference. |
| imessage-exporter/src/exporters/txt/view_model.rs | Removes unused TXT Digital Touch template VM. |
| imessage-exporter/src/exporters/txt/templates/balloons/digital_touch.txt | Removes TXT Digital Touch debug template. |
| imessage-exporter/src/exporters/txt/mod.rs | Updates TXT tests to parse real Digital Touch payloads and assert rendered summaries. |
| imessage-exporter/src/exporters/txt/balloons.rs | Switches TXT rendering from debug template to DigitalTouchMessage::render_text(). |
| imessage-exporter/src/exporters/shared/balloon.rs | Routes Digital Touch messages through DigitalTouchMessage::from_payload() and propagates detailed errors. |
| imessage-exporter/src/exporters/html/view_model.rs | Removes unused HTML Digital Touch template VM. |
| imessage-exporter/src/exporters/html/templates/balloons/digital_touch.html | Removes HTML Digital Touch debug template. |
| imessage-exporter/src/exporters/html/resources/style.css | Adds layout rules for Digital Touch SVG/video display. |
| imessage-exporter/src/exporters/html/mod.rs | Updates/adds HTML tests to validate SVG output for Digital Touch messages. |
| imessage-exporter/src/exporters/html/balloons.rs | Implements HTML Digital Touch rendering, including attachment-backed media handling and fallback behavior. |
| imessage-exporter/src/exporters/formatter.rs | Updates BalloonFormatter signature to accept DigitalTouchMessage. |
| imessage-database/src/message_types/text_effects/text_effect.rs | Adjusts module import path. |
| imessage-database/src/message_types/digital_touch/*.rs | Adds full Digital Touch parsing and SVG/text rendering implementation across effects (tap/sketch/kiss/heartbeat/fireball/media) plus shared SVG builder. |
| imessage-database/src/message_types/digital_touch/digital_touch.proto | Documents and extends Digital Touch protobuf schema (adds Media). |
| imessage-database/src/message_types/digital_touch/digital_touch_proto.rs | Regenerates protobuf bindings to include Media. |
| imessage-database/src/error/plist.rs | Extends PlistParseError to carry underlying DigitalTouchError. |
| imessage-database/src/error/mod.rs | Exposes new digital_touch error module. |
| imessage-database/src/error/digital_touch.rs | Adds DigitalTouchError for parse/archive/validation failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


