feat(ask-red-hat): add <rhx-ask-red-hat>#29
Open
zeroedin wants to merge 35 commits into
Open
Conversation
|
|
Size Change: +3.08 kB (+14.72%) Total Size: 24 kB
ℹ️ View Unchanged
|
✅ Deploy Preview for rhds-extensions ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
<cp-ask-red-hat>to<rhx-ask-red-hat><rhx-ask-red-hat-button>. TBD on if this component is necessary, but a similar button is being used on docs.redhat.com; it would be nice to encapsulate the style for reuse.<rhx-ask-red-hat>this is in contrast to the currently existing<cp-ask-red-hat>which requires authentication to display.<rhx-ask-red-hat>component will be visible to all users, unlike its predecessor.Updated elements / docs to support color scheme tokenscherry picked out of this PR and merged in docs: updates, dev server, color scheme, documentation #36Closes #30
TODO:
<rhx-ask-red-hat>to<rhx-ask-red-hat-link>with the addition of<rhx-ask-red-hat-button>to avoid confusion. Or are we deleting both components and focus on implementation in RHDS.Testing Instructions
Notes to Reviewers
Becauserhx-ask-red-hatrequires an authentication source, the component is difficult to test. Copying and pasting token values and userId from a primer authentication and adding those to the component is the only viable option at this time.This is no longer an issue, as the authentication is being removed.