Skip to content

CherryPicked: [v4.18] fix(deps): move ruff to dev deps & widen requires-python for Python 3.14 - #2785

Open
manage-repositories-app[bot] wants to merge 2 commits into
v4.18from
CherryPicked-fix/move-ruff-to-dev-deps-bGKWz
Open

CherryPicked: [v4.18] fix(deps): move ruff to dev deps & widen requires-python for Python 3.14#2785
manage-repositories-app[bot] wants to merge 2 commits into
v4.18from
CherryPicked-fix/move-ruff-to-dev-deps-bGKWz

Conversation

@manage-repositories-app

@manage-repositories-app manage-repositories-app Bot commented Aug 6, 2026

Copy link
Copy Markdown

Summary

Cherry-pick and follow-up fix for the v4.18 branch:

  1. Move ruff to dev dependencies — cherry-picked from main (original PR: fix(deps): move ruff from runtime to dev dependency group #2780, owner: rnetser). Moves ruff from runtime dependencies to the dev dependency group so it is not installed with the package.
  2. Widen requires-python — updates requires-python from ">=3.9, <3.14" to ">=3.9, <3.15" so installs succeed on CI hosts running Python 3.14.6 (fixes python-module-install failure).

Commits

ruff is a linter/formatter — it has no runtime purpose and adds ~11MB
of platform-specific binaries to every install. It is already managed
via pre-commit hooks (ruff-pre-commit), so it only needs to be
available for local development.

Move ruff from dependencies to [dependency-groups] dev.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot1

Copy link
Copy Markdown

⚠️ This cherry-pick had conflicts resolved by AI (claude/claude-opus-4-6-1m)

@rnetser — AI automatically resolved merge conflicts for this cherry-pick. Please review the changes carefully and verify correctness before merging.

@redhat-qe-bot

Copy link
Copy Markdown
Contributor

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

Note: You are an auto-verified user. Your PRs will be automatically verified and may be auto-merged when all requirements are met.

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: Disabled for this repository
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (PR author or approvers)
  • /hold cancel - Unblock PR merging (PR author or approvers)
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message
  • /security-override - Set security check runs to pass (maintainers only)
  • /security-override cancel - Re-run security checks

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest python-module-install - Test Python package installation
  • /retest conventional-title - Validate commit message format
  • /retest all - Run all available tests

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3
  • /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

  • /rebase - Rebase this PR branch onto its base branch

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. Status Checks: All required status checks must pass
  3. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  4. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • myakove
  • rnetser

Reviewers:

  • dbasunag
  • myakove
  • rnetser
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • automerge
AI Features
  • Conventional Title: Mode: fix (claude/claude-opus-4-6-1m)
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)
Security Checks
  • Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
  • Committer Identity Check: Verifies last committer matches PR author
  • Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@myakove

myakove commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve
/verified

The CI server runs Python 3.14.6, which was excluded by the
previous upper bound (<3.14). Widen to <3.15 so the package
installs on Python 3.14.x.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rnetser rnetser changed the title CherryPicked: [v4.18] fix(deps): move ruff from runtime to dev dependency group CherryPicked: [v4.18] fix(deps): move ruff to dev deps & widen requires-python for Python 3.14 Aug 6, 2026
@rnetser

rnetser commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

/security-override

@redhat-qe-bot2

Copy link
Copy Markdown

Security checks overridden by @rnetser. Security check runs set to pass.

@rnetser

rnetser commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

/verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants