Config: expose the theme default via env - #1575
Merged
Baskarayelu merged 4 commits intoJul 30, 2026
Merged
Conversation
Conflict resolution for PR Remitwise-Org#1575.
Conflict resolution for PR Remitwise-Org#1575.
Conflict resolution for PR Remitwise-Org#1575.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default theme (applied when a visitor has no stored
theme-preferenceyet) was hardcoded to"system"in two places:ThemeContext.tsx's initial state and the inline pre-hydration script inapp/layout.tsx. AddsgetDefaultThemePreference()(lib/config/theme.ts), readingNEXT_PUBLIC_DEFAULT_THEMEand falling back to"system"when unset/invalid, and wires it into both places so they stay in sync (see the "why two copies" note added in #1574'sdocs/THEMING.mdupdate).Testing
node node_modules/vitest/vitest.mjs run ... tests/unit/config/theme.test.ts tests/unit/context/ThemeContext.test.tsx-- 8/8 pass (3 new)npm run test:unit:vitest-- 300 passing (was 297 onmain), zero regressionsnpx eslint lib/config/theme.ts lib/context/ThemeContext.tsx app/layout.tsx tests/unit/config/theme.test.ts-- cleannpx tsc --noEmit-- no new errors in any touched fileCloses #1498