fix: use start_webhook instead of run_webhook for async context#196
Open
Jecvay wants to merge 2 commits intoRichardAtCT:mainfrom
Open
fix: use start_webhook instead of run_webhook for async context#196Jecvay wants to merge 2 commits intoRichardAtCT:mainfrom
Jecvay wants to merge 2 commits intoRichardAtCT:mainfrom
Conversation
run_webhook() manages its own event loop, which conflicts with asyncio.run() and causes "Cannot close a running event loop" error. Switch to start() + start_webhook() pattern, matching how polling mode already uses start_polling(). Also add "webhooks" extra to python-telegram-bot dependency, which is required by start_webhook(). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Verify that start_webhook is used instead of run_webhook in async context, and that polling mode is unaffected by the fix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_webhook()withstart()+start_webhook()to fix "Cannot close a running event loop" error whenWEBHOOK_URLis configuredrun_webhook()internally manages its own event loop, which conflicts with the existingasyncio.run(main())insrc/main.pystart_polling()— consistent async lifecycle management"webhooks"extra topython-telegram-botdependency (required bystart_webhook())Test plan
WEBHOOK_URLset → starts successfully,setWebhookreturns 200 OKWEBHOOK_URL→ polling mode still works as before🤖 Generated with Claude Code