fix: correct @param types in Javadoc for listener methods and README typos - #429
Open
2300031193 wants to merge 1 commit into
Open
fix: correct @param types in Javadoc for listener methods and README typos#4292300031193 wants to merge 1 commit into
2300031193 wants to merge 1 commit into
Conversation
…typos addBinderDeadListener: @param was 'OnBinderReceivedListener', corrected to 'OnBinderDeadListener' addRequestPermissionResultListener: @param was 'OnBinderReceivedListener', corrected to 'OnRequestPermissionResultListener' README: fix typos 'Differents' -> 'Differences', 'betweent' -> 'between'
stevenfaelber88-png
approved these changes
Jun 1, 2026
stevenfaelber88-png
approved these changes
Jun 1, 2026
patrzyszco78-png
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix incorrect
@paramtype names in Javadoc for listener methods inShizuku.java,and fix two typos in
README.md.Why
These are copy-paste errors in the documentation:
addBinderDeadListener()had@param listener OnBinderReceivedListener→ should be
OnBinderDeadListeneraddRequestPermissionResultListener()had@param listener OnBinderReceivedListener→ should be
OnRequestPermissionResultListenerThese mislead developers reading the generated Javadoc.
Changes
api/src/main/java/rikka/shizuku/Shizuku.java— 4 Javadoc@paramcorrectionsREADME.md— fix typos: "Differents" → "Differences", "betweent" → "between"Type of Change