fix: avoid out of bounds index in PyRoaringBitMap124 test #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are only 28 bytes of data, but a size of 36 was being passed. Instead, make this impossible: convert to a stack array, and use sizeof rather than a magic number to pass the length of data. It isn't clear where the test data came from: the linked issue includes a base64 input of `OjAAAAEAAAAAAAkAEAAAADIAMwA0ADUANgA3ADgAOgA7ADwA`, which _does_ expand to 36 bytes, so additionally, this replaces the test data with the decoded value of the data from the linked issue instead. This was (correctly) failing in ASAN when we immediately read past the end of the string literal.
Member
Author
|
@lemire I'm not fully sure what the test is supposed to be doing. The data from the python issue is a valid portable serialization, so maybe the change of data was intentional, but the length wasn't updated? |
Member
|
@Dr-Emann Let me have a look. |
lemire
approved these changes
May 19, 2025
Member
lemire
left a comment
lemire
left a comment
There was a problem hiding this comment.
This is a good fix. I will merge immediately.
Member
|
I will now proceed to verify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only 28 bytes of data, but a size of 36 was being passed. Instead, make this impossible: convert to a stack array, and use sizeof rather than a magic number to pass the length of data.
It isn't clear where the test data came from: the linked issue includes a base64 input of
OjAAAAEAAAAAAAkAEAAAADIAMwA0ADUANgA3ADgAOgA7ADwA, which does expand to 36 bytes, so additionally, this replaces the test data with the decoded value of the data from the linked issue instead.This was (correctly) failing in ASAN when we immediately read past the end of the string literal.
This is a bug, but a bug that only exists in the tests, no actual CRoaring code is affected.