Skip to content

Add pointcloud-to-laserscan to windows build #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traversaro merged 1 commit into from
Apr 22, 2026
Merged

Add pointcloud-to-laserscan to windows build #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions patch/ros-jazzy-pointcloud-to-laserscan.win.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index d13488c..4d175f5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -3,6 +3,11 @@ project(pointcloud_to_laserscan)

find_package(ament_cmake REQUIRED)

+# MSVC does not define M_PI by default
+if(MSVC)
+ add_compile_definitions(_USE_MATH_DEFINES)
+endif()
+
find_package(laser_geometry REQUIRED)
find_package(message_filters REQUIRED)
find_package(rclcpp REQUIRED)
2 changes: 1 addition & 1 deletion vinca.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ packages_select_by_deps:
- data_tamer_cpp

- point_cloud_transport_py
- pointcloud_to_laserscan

# SICK LiDAR drivers
- sick_scan_xd
Expand Down Expand Up @@ -267,7 +268,6 @@ packages_select_by_deps:
# see https://github.com/RoboStack/ros-jazzy/pull/79#issuecomment-2993499990
- grid_map
- dual-laser-merger
- pointcloud-to-laserscan
- laser-segmentation
- rqt_tf_tree
- rviz_satellite
Expand Down
Loading