Open
Conversation
missxa
requested changes
Dec 27, 2023
Contributor
missxa
left a comment
There was a problem hiding this comment.
It's a good practice to add a description of added code in a PR. Would be great to have a summary of added features in the future. Also, for the future please work on a separate branch directly in this repo, since now I cannot directly comment on your python file in the fork.
Architecture & design:
- as discussed, it is better to implement a node for a single camera. please change the implementation accordingly. in case more cameras are added to the robot, then launch another node using the camera name for the topic and node names (like you do already)
- publish absolute proximity in meters, not relative_proximity. for the operator meters are much more understandable and it doesn't require knowing that current threshold is
Implementation:
- 10 hz publisher is too low, use 40 hz or higher
- use our established topic naming scheme, i.e.
/roboy/pinky/sensing/your/stuff - call the
thresholdparameterproximity_warning_threshold(also, it can be potentially different for different cameras) - set default threshold to 0.2 m in the launch file
- if exception occurs, use node logger's
errorand not justprint
…n/Peripheral-SS23 into arkadiy/proximity_warning
Author
|
@missxa cleaned up code integrating all the requested changes |
Author
|
@missxa did you have a chance to take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see https://github.com/arkadiy-telegin/proximity_monitor/blob/master/proximity_monitor/proximity_monitor.py