-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Added "script" mode for execute_command on Windows #9882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Re-review completed. 3 of 4 issues have been resolved. 1 issue remains:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
8e11e1c to
44629d5
Compare
Re-review completed. 3 of 4 issues have been resolved. 1 issue remains:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
44629d5 to
12e7129
Compare
Signed-off-by: Denis Kudelin <[email protected]>
12e7129 to
262cbc0
Compare
Related GitHub Issue
Closes: #9881
Description
execute_command: acceptsscript_content+script_runner, writes to a temp file, runs, deletes.Test Procedure
pnpm vsix(full bundle build).execute_commandusingscript_content/script_runner→ expect temp script executes and is deleted.commandpath is available and works.Pre-Submission Checklist
Screenshots / Videos
N/A (settings toggle reuses existing UI).
Documentation Updates
Additional Notes
Temp script auto-cleans; script mode exposed only on Windows with the toggle.
Get in Touch
Discord: denis.kudelin
Important
Adds Windows-only script execution mode to
execute_command, controlled by a new settingwindowsScriptExecutionEnabled.execute_commandinexecute_command.ts, usingscript_contentandscript_runner.windowsScriptExecutionEnabledsetting inglobal-settings.ts.windowsScriptExecutionEnabledinTerminalSettings.tsx.SettingsView.tsxto include new setting.ExtensionStateContext.tsxto handle new setting.ChatView.tsxto handle command execution changes.This description was created by
for 44629d5. You can customize this summary. It will automatically update as commits are pushed.