feat: improve condensing UI styling to match API request component #9928
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Reviewed the styling changes to the
No issues found. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
brunobergher
reviewed
Dec 8, 2025
Collaborator
brunobergher
left a comment
brunobergher
left a comment
There was a problem hiding this comment.
Left some comments
| }} | ||
| onClick={() => setIsExpanded(!isExpanded)}> | ||
| <div className="flex items-center gap-2 flex-grow"> | ||
| <div style={{ display: "flex", alignItems: "center", gap: "10px", flexGrow: 1 }}> |
Collaborator
There was a problem hiding this comment.
We should stick to tailwind classes
| "tokens": "tokens", | ||
| "condensation": { | ||
| "title": "Context Condensed", | ||
| "title": "context condensed", |
Collaborator
There was a problem hiding this comment.
Nope, "Context consensed", sentence case. And we need to update other locales accordingly.
| <span className={`codicon codicon-chevron-${isExpanded ? "up" : "down"}`}></span> | ||
| <div className="flex items-center gap-2"> | ||
| <div | ||
| className="text-xs text-vscode-dropdown-foreground border-vscode-dropdown-border/50 border px-1.5 py-0.5 rounded-lg" |
Collaborator
There was a problem hiding this comment.
We need to check visually, but this seems to match the code I wanted it to
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the condensing UI component styling to match the API request component style as discussed in Slack.
Changes
Visual Comparison
The condensing component now has the same visual treatment as the API request component:
View task on Roo Code Cloud