-
Notifications
You must be signed in to change notification settings - Fork 280
Symphonia custom registry support #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Symphonia custom registry support #806
Conversation
Signed-off-by: royalmustard <[email protected]>
|
Wonderful idea :) What do you think of adding these behind a cargo feature and doing the |
|
as in adding a |
|
I tend to agree that the power in this feature would be precisely to expose it to users. |
|
I like it. Can you find a public-domain Something as hybrid with what @dvdsk suggested, because Opus support is a requested feature, could we also offer a I expect Opus support to be come merged in to Symphonia eventually, but not soon. |
|
This is great, before as a get around for opus decoding I made a custom FFmpeg Source to use FFmpeg to decode opus Although this is not as a great as a first party solution, It's still great compared to using FFmpeg would be cool to see in rodio.
Yep, only the initial work has really started here pdeljanov/Symphonia#398 and Tracking of opus as a whole started here 5 years ago pdeljanov/Symphonia#8 |
|
Before merging this, you might want to update |
This PR add support for using a custom codec registry with the symphonia backend.
This allows easily add support for additional codecs, many of which are already supported by third party addons for symphonia (e.g. opus).
To use a custom registry, a (global) codec registry must be instantiated and all desired codecs must be registered in it.
Then, this registry can be given to a
DecoderBuildervia thewith_codec_registryfunction.If no custom registry is given to the builder, the decoder will use symphonia's default registry, as before.