chore(deps): remove unused devDependencies (colors, ts-node, stylelint-config-standard, chromatic) - #6412
chore(deps): remove unused devDependencies (colors, ts-node, stylelint-config-standard, chromatic)#6412droshev wants to merge 1 commit into
Conversation
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MariaIDineva
left a comment
There was a problem hiding this comment.
One from Claude:
[.github/actions/generate-conventional-release-notes/closest-version.mjs:3]
Issue: The git-semver-tags npm package is not unused — it is actively imported in this file:
import gitSemverTags from 'git-semver-tags';
The code calls it with the npm callback API (gitSemverTags({ tagPrefix: 'v', skipUnstable: false }, function(err, result) {...})). Removing the package will break the generate-conventional-release-notes GitHub Action at runtime.
The PR description states "The npm package is never imported" — this is incorrect. The custom helper at .github/actions/helpers/git-semver-tags.mjs uses a completely different API (positional args, synchronous, no callback, no tagPrefix option) and cannot be a drop-in substitute without also updating closest-version.mjs.
Fix: Either:
- Keep git-semver-tags in devDependencies, OR
- Update closest-version.mjs to use the custom helper's API before removing the package.
…ts-node, stylelint-config-standard, chromatic) [ci visual]
70c2482 to
234bff3
Compare
Removes 4 packages that are no longer used in the codebase: