Skip to content

chore(deps): remove unused devDependencies (colors, ts-node, stylelint-config-standard, chromatic) - #6412

Open
droshev wants to merge 1 commit into
mainfrom
chore/remove-unused-packages-2
Open

droshev wants to merge 1 commit into
mainfrom
chore/remove-unused-packages-2

Conversation

@droshev

@droshev droshev commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Removes 4 packages that are no longer used in the codebase:

Package Reason
colors No imports or requires anywhere. Added in #3087 (webpack 5 / Windows compat migration, Jan 2022) — the code that needed it is long gone.
ts-node Only reference was the transform-stories script pointing to stories-transformer.ts, which doesn't exist. Config block in tsconfig.base.json also removed.
stylelint-config-standard Redundant — already a transitive dependency of stylelint-config-standard-scss, which is what .stylelintrc.json actually extends.
chromatic CI uses chromaui/action@v18.10.1, which bundles its own CLI. No npm script references the chromatic CLI. Not used locally either.

@droshev
droshev requested a review from a team October 2, 2026 12:50
@droshev droshev self-assigned this Oct 2, 2026
@droshev droshev added Dependencies Pull requests that update a dependency file tooling labels Oct 2, 2026
@droshev droshev added this to the Sprint 163 - October 2026 milestone Oct 2, 2026
@netlify

netlify Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 234bff3
🔍 Latest deploy log https://app.netlify.com/projects/fundamental-styles/deploys/6abfc40948fbf90008f02bf9
😎 Deploy Preview https://deploy-preview-6412--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@MariaIDineva MariaIDineva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One from Claude:

[.github/actions/generate-conventional-release-notes/closest-version.mjs:3]
Issue: The git-semver-tags npm package is not unused — it is actively imported in this file:

import gitSemverTags from 'git-semver-tags';

The code calls it with the npm callback API (gitSemverTags({ tagPrefix: 'v', skipUnstable: false }, function(err, result) {...})). Removing the package will break the generate-conventional-release-notes GitHub Action at runtime.

The PR description states "The npm package is never imported" — this is incorrect. The custom helper at .github/actions/helpers/git-semver-tags.mjs uses a completely different API (positional args, synchronous, no callback, no tagPrefix option) and cannot be a drop-in substitute without also updating closest-version.mjs.

Fix: Either:

  • Keep git-semver-tags in devDependencies, OR
  • Update closest-version.mjs to use the custom helper's API before removing the package.

…ts-node, stylelint-config-standard, chromatic) [ci visual]
@droshev
droshev force-pushed the chore/remove-unused-packages-2 branch from 70c2482 to 234bff3 Compare October 2, 2026 14:47
@droshev droshev changed the title chore(deps): remove unused devDependencies (colors, git-semver-tags, ts-node, stylelint-config-standard, chromatic) chore(deps): remove unused devDependencies (colors, ts-node, stylelint-config-standard, chromatic) Oct 2, 2026
@droshev
droshev requested a review from MariaIDineva October 2, 2026 14:48

This branch was successfully deployed

1 active deployment
ci — 234bff3a Deployed Oct 2, 2026 by droshev via Install, Lint, Build #3357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants