Updates for first reprocessing of PDS products in spring productions #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plate It used to end when the template SPR goes under 1e-4 ADC#. Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds. This should make it possible to include undershootings. All these parameters are currently hard-coded.
…icles that might cross cathode
Good catches on names and strings. Co-authored-by: Copilot <[email protected]>
Trigger simulation modules now support input tags with process name [private]
mvicenzi
requested review from
PetrilloAtWork,
SFBayLaser,
gputnam and
icaromx
This was referenced Dec 8, 2025
Also requires the replacement of obsolete CreateAssns().
* removed unused headers and dependencies, added missing ones * updated exception error message * using `make_unique()` instead of `new`
Algorithmic code is still there, probably unused.
Also fixed a preexisting issue with (obsolete) FHiCL job configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the required updates and fhicls to enable the first reprocessing of light products for the SBN2025 spring productions (both MC and data). In particular, the following changes are implemented:
This PR depends on:
icarus_dataupdate with new SPR responses