doc(coverage): two of the three "untested" functions cannot be covered there - #61
Merged
Merged
Conversation
…d there This file has said since yesterday that the never-entered bucket's untested-behaviour group is down to three functions. Only ONE of them is a gap in the suite. geoEntityValidate lives in plugins/shared/, which no run excludes, and is called only from plugins/currentState/corDB/, which a mongoc run DOES exclude. It can never be non-zero in the mongoc column, whatever anyone writes - and all four of its diagnostics are already asserted, by geoproperty_degenerate_polygon and three others. attrInstanceOf is the same shape one level up: reached only when the broker evaluates `q` in-process, which a mongoc query does not do. ⭐ The mongoc run's never-entered list contains functions only the corDB path can reach, and vice versa. The file already says this about the corDB column - "a property of the run, not of the code" - and the mirror case is easy to miss, because a mongoc-only zero looks exactly like an untested function until you follow the caller. Both of these were chased as gaps before anyone did, which is how the correction came to be needed. corRestClientResponseHeader remains, and is real: it needs a Context Source answering 3xx WITH a Location header, which ftClient's /mock/reply cannot express.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/coverage.mdhas said since yesterday that the never-entered bucket's untested-behaviour group is down to three functions. Only one of them is a gap in the suite.geoEntityValidatelives inplugins/shared/, which no run excludes, and is called only fromplugins/currentState/corDB/, which a mongoc run does exclude. It can never be non-zero in the mongoc column, whatever anyone writes — and all four of its diagnostics are already asserted, bygeoproperty_degenerate_polygonand three others.attrInstanceOfis the same shape one level up: it is reached only when the broker evaluatesqin-process, which a mongoc query does not do.⭐ The mongoc run's never-entered list contains functions only the corDB path can reach, and vice versa. The file already says this about the corDB column — "a property of the run, not of the code" — and the mirror case is easy to miss, because a mongoc-only zero looks exactly like an untested function until you follow the caller. Both of these were chased as gaps before anyone did, which is how the correction came to be needed.
corRestClientResponseHeaderremains, and is real: it needs a Context Source answering 3xx with aLocationheader, which ftClient's/mock/replycannot express.Documentation only — no code, no test impact.