feat(transferType): make catalog transferType configurable via product spec - #22
Merged
Merged
Conversation
wistefan
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catalog Distribution format (the DSP transferType the consumer requests) was hardcoded, so the dashboard only offered a value that didn't match what the data plane supports. Read it from a
transferTypeproduct-spec characteristicinstead, defaulting to HttpData-PULL when absent (backwards compatible) and omitting the dataset with a warning when an unsupported type is declared.
Consolidate the supported transfer types into a single TransferTypes class in tmf-extension, referenced by both the catalog mapper and the data-plane registration / resource generators, so the allowed set lives in one place.