Skip to content

feat(endpoint): add support for transferPath and replace token key to authorization with bearer - #23

Merged
vramperez merged 2 commits into
mainfrom
feat/transferPath-and-authorization-field
Jul 1, 2026
Merged

feat(endpoint): add support for transferPath and replace token key to authorization with bearer#23
vramperez merged 2 commits into
mainfrom
feat/transferPath-and-authorization-field

Conversation

@vramperez

Copy link
Copy Markdown
Collaborator

No description provided.

@vramperez
vramperez requested review from Mortega5 and wistefan June 29, 2026 15:30
@@ -0,0 +1,71 @@
/*
* Copyright 2025 Seamless Middleware Technologies S.L and/or its affiliates

@Mortega5 Mortega5 Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double copyright?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is the correct now (https://github.com/SEAMWARE/fdsc-edc/blob/main/license-header.txt). The other one seems to be a legacy one, used in the past maybe with license-maven-plugin or something like that

FDSCDataAddress.Builder.newInstance()
.clientId(dataFlow.getId())
.property(EDC_NAMESPACE + "token", signedJWT.serialize())
.property(EDC_NAMESPACE + "authorization", "Bearer " + signedJWT.serialize())

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the bearer prefix expected by the frontend? I checked the spec and they define the optional "authType" property, that contains the info of it being a bearer token: https://eclipse-dataspace-protocol-base.github.io/DataspaceProtocol/2025-1-err1/#transfer-start-message

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our current implementation, I saw that under tokenType

{
  "@type": "DataAddress",
  "tokenType": "bearer",
  ...
}

I'll change it and try again with the UI

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in our implementation it was wrong in any way...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 0abed1c

@vramperez
vramperez merged commit daf45fa into main Jul 1, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants