Skip to content

ci: upgrade codecov-action #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SF-Zhou merged 2 commits into from
Mar 5, 2026
Merged

ci: upgrade codecov-action #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b377a4
ci: upgrade codecov-action
SF-Zhou Mar 5, 2026
9ab19d7
chore: remove useless licenses
SF-Zhou Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,16 @@ jobs:
cargo llvm-cov report --cobertura --output-path target/llvm-cov-target/cobertura.xml

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
Comment on lines 34 to 36
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is titled as a CI-only Codecov action upgrade, but it also deletes licenses/rust/LICENSE-{MIT,APACHE}. If those files were kept for third-party license attribution/compliance, they should not be removed; otherwise please update the PR title/description (or split into a separate PR) to reflect the licensing change explicitly.

Copilot uses AI. Check for mistakes.
token: ${{ secrets.CODECOV_TOKEN }}
slug: SF-Zhou/lockmap
files: target/llvm-cov-target/cobertura.xml

- name: Upload test results to Codecov
uses: codecov/test-results-action@v1
uses: codecov/codecov-action@v5
with:
report_type: test_results
Comment on lines +42 to +44
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Upload test results" step switches from codecov/test-results-action@v1 to codecov/codecov-action@v5 and introduces report_type: test_results. Since this changes the upload mechanism, please confirm this is the supported way to upload JUnit results with v5 (and that the inputs are correct). If not, keep using the dedicated codecov/test-results-action for test results while upgrading only the coverage upload step.

Suggested change
uses: codecov/codecov-action@v5
with:
report_type: test_results
uses: codecov/test-results-action@v1
with:

Copilot uses AI. Check for mistakes.
token: ${{ secrets.CODECOV_TOKEN }}
slug: SF-Zhou/lockmap
files: target/nextest/default/junit.xml
Expand Down
176 changes: 0 additions & 176 deletions licenses/rust/LICENSE-APACHE
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions licenses/rust/LICENSE-MIT
View file
Open in desktop

This file was deleted.