Repository navigation
convert: fix converting recent AoE2: DE builds - #1824
Merged
Merged
Conversation
Since 72b7ee4, get_real_type raises for members that have an object type. _type_conversion and _get_primitive_value_str expect those to pass through, so converting any game failed while generating the pregen objects.
52dca96 made image_metadata a list to match its annotation, but merge_frames and the metadata exporters use it as a dict with the "size" and "subtex_metadata" keys. Fix the annotation instead.
Build 25464371 uses the effect types 31 and 36, which made reading the dat file fail. Like the other unknown types, they are not converted.
target_mode is an object member, so nyan only allows assigning it. The new tech 1379 in recent AoE2: DE builds changes ballistics with a relative effect, which produced a "+=" patch that fails to load.
Tech 1474 in recent AoE2: DE builds changes the max projectiles of melee units as well, which produced ShootProjectile patches on their ApplyDiscreteEffect attack. The other projectile upgrades already check for projectile shooters.
TheJJ
approved these changes
Oct 14, 2026
Member
|
awesome, thanks for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting AoE2: DE (build 25464371, the macOS version from Steam) failed in three places:
get_real_type()raises for members with an object type, which breaks generating the pregen objects for every gameTexture.image_metadatais a list, butmerge_framesand the metadata exporters use it as a dictAfter that, the engine couldn't load the converted modpack because of two new techs:
+=patch ontarget_modeShootProjectilepatches on their melee attackWith these changes the conversion runs through, the game loads
de2_base, andmake checkmergeandmake testpass.Side note: when an export worker raises, the converter doesn't exit but keeps printing the progress line forever.