fix: restore main to a compiling, fully testable state

[EmmanuelOchaje]

Summary

main has not compiled since 25 Jul 2026 (009cefb). This restores it to a compiling, fully testable state — mechanical fixes only, no behavioural or logic changes.

Class 1 — oracle wouldn't compile

Soroban caps contract function names at 32 characters. register_market_for_circuit_breaker (35 chars) exceeded that, and since most of the workspace depends on oracle, this single error stopped the entire build.

⚠️ Breaking ABI change: the function is renamed to register_market_for_breaker (27 chars). It's an uncalled, dead public entrypoint (kept per the issue's instructions — not removed, since that's a separate API decision), so nothing in this repo invokes it, but it is a public contract entrypoint and its name is part of the on-chain ABI. docs/auth-audit.md is regenerated (python3 scripts/gen_auth_audit.py) to reflect the new name and pick up other drift that had accumulated since the doc was last generated. If any off-chain caller (frontend, indexer, keeper script) invokes this function by name, it needs updating.

Class 2 — test-only compilation errors, once Class 1 cleared

market_token::initialize gained two parameters (long_token, short_token) without updating its ~35 #[cfg(test)] call sites across the workspace. Fixed each one — mostly reordering token creation to happen before market-token registration, since the new params need the token addresses up front.

Cargo halts at the first failing crate, so fixing that cascaded into a long tail of further test-only breakage that had been silently accumulating (570 test functions were added between 18 Jun and 28 Jul, none of which had run since). Iterated until cargo check --workspace --all-targets was clean:

• Two documented oracle test failures (soroban-sdk 25.3.1 event-testing API: Events::all() renamed, Val: From<Symbol> no longer holds — now uses topics.contains(&symbol_short!(..).to_val()) and asserts the emitted event via soroban_sdk::vec![...] equality instead of decoding it back out).
• Stale CreateOrderParams/PositionProps struct literals (missing/extra expiry_ledger field) left behind by an earlier field addition.
• Several call sites left behind by unrelated signature changes: reader::initialize, fee_handler::initialize, liquidation_handler::liquidate_position, adl_handler::execute_adl, fee_handler::claim_fees, order_cleanup::cancel_expired_order, data_store::set_u128's key type, order_handler::create_order's now-explicit caller argument.
• Missing soroban_sdk::testutils::{Ledger, Events, BytesN} trait imports for methods that had always needed them but were never reached because compilation failed earlier.

Clippy

cargo clippy --workspace --all-targets -- -D warnings was not passing before this PR either (400+ pre-existing warnings, unrelated to the two classes above — mostly literal digit-grouping style, a few genuinely dead test-fixture fields, deprecated SDK renames). Since it's in this issue's acceptance criteria, fixed all of it:

• 183 inconsistent digit-grouping literals reformatted (e.g. 1_000_0000 → 10_000_000) — same value, different underscore placement.
• Deprecated SDK renames with identical behaviour: env.budget() → env.cost_estimate().budget(), register_contract(None, X) → register(X, ()), deployer.deploy(hash) → deploy_v2(hash, ()).
• #[allow(clippy::too_many_arguments)] added to the dozen functions already at 8–9 params, matching the existing precedent in libs/swap_utils and libs/pricing_utils.
• #[allow(dead_code)] on test-fixture World/TestWorld structs whose fields aren't all read by every test in the file — matches this codebase's existing precedent for the same lint on contractclient trait stubs.
• Two manual if/else zero-checks before division rewritten as checked_div (same behaviour).
• A stray duplicate doc-comment block in reader.rs removed, and one helper function moved above its #[cfg(test)] mod tests block (clippy::items_after_test_module) — pure relocation/dedup, same code.
• One deliberate deviation, called out explicitly: ~50 call sites still use the deprecated env.events().publish((topic,), data) API instead of the newer #[contractevent] macro (which roughly half the codebase's events already use). Migrating the rest changes the on-chain topic/data encoding for each event — a real ABI-facing change, not a lint fix, and out of scope for a compilation-restoration PR per the issue's own "no behavioural changes" instruction. Suppressed with #![allow(deprecated)] at the crate level (with an explanatory comment), matching this repo's own existing precedent for the same lint in test_faucet/test_token.

Test results

cargo test --workspace --no-fail-fast:

528 passed; 37 failed; 5 ignored  (570 total)

None of the 37 are new — they were unreachable before this PR (the crate wouldn't compile), so there was no way to know whether they were live bugs or untested. Per the issue's scope, no assertions were changed to force a green suite. Full breakdown, grouped by crate/root-cause cluster, is tracked in #668.

Verification

• cargo check --workspace exits 0
• cargo clippy --workspace --all-targets -- -D warnings exits 0
• cargo test --workspace compiles and runs to completion (528 passed / 37 failed / 5 ignored — see Triage the 37 pre-existing test failures uncovered by #529 #668)
• stellar contract build succeeds for all 23 contracts in CONTRACTS (mx/common.mk)
• docs/auth-audit.md regenerated and in sync (python3 scripts/gen_auth_audit.py --check)

Closes #529