Add tests for encoding/decoding a pfx. - #78
Open
bernata wants to merge 1 commit into
Open
Conversation
Verify each of the encoders: Legacy, LegacyRC2, LegacyDES, Modern2023, Modern2026.
Author
|
Hi @AGWA , i was hoping to add these tests to validate the "end-to-end" api flow. |
Author
|
@AGWA - just checking in to get your thoughts on this pr. If we could merge this pr, then i have some ideas around how the code uses sha1 to produce a key id. Using sha1 fails in fips mode, but i think there are a few ways to be backward compatible but still enable the option to use something other than sha1. This pr would be testing that codepath. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify each of the encoders: Legacy, LegacyRC2, LegacyDES, Modern2023, Modern2026.