Skip to content

Feat #1275 Made the rule Verificattion more user friendly by showing rows with violating things#1448

Merged
rdevoogtatstariongroup merged 2 commits into
developmentfrom
feat/gh1275-UserFriendlyFeedbackRuleVerification
Jun 29, 2026
Merged

Feat #1275 Made the rule Verificattion more user friendly by showing rows with violating things#1448
rdevoogtatstariongroup merged 2 commits into
developmentfrom
feat/gh1275-UserFriendlyFeedbackRuleVerification

Conversation

@rdevoogtatstariongroup

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-IME code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Feat #1275
Rule violations now expand to show the violating model items, with a context-menu "Highlight" that flags them in both the Element Definition browser and the Product Tree.

The Status column now reflects the actual outcome: fixed RuleVerificationService so BuiltIn (and User) verifications persist PASSED/FAILED instead of always NONE via the write transaction instead of in-memory.

Also fixed non-persistent RuleViolations being wiped, so BuiltIn violations are finally shown

image

Comment thread CDP4Composition/Services/RuleVerification/RuleVerificationService.cs Outdated
Comment thread CDP4Composition/Services/RuleVerification/RuleVerificationService.cs Outdated
Made the rule Verificattion more user friendly by showing rows with violating things from which you could edit and inspect below the violationrow and implemented a highlight for the elments in elementdefinition browser and producttree
@rdevoogtatstariongroup
rdevoogtatstariongroup force-pushed the feat/gh1275-UserFriendlyFeedbackRuleVerification branch from 12b1beb to b9ac3ea Compare June 29, 2026 14:23
@rdevoogtatstariongroup
rdevoogtatstariongroup merged commit 825fc85 into development Jun 29, 2026
2 checks passed
@rdevoogtatstariongroup
rdevoogtatstariongroup deleted the feat/gh1275-UserFriendlyFeedbackRuleVerification branch June 29, 2026 14:29
@rdevoogtatstariongroup rdevoogtatstariongroup linked an issue Jun 29, 2026 that may be closed by this pull request
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule verification: add user-friendly feedback

2 participants