Skip to content

Feat #734 added the possibility to drag a subscribed parameter into the dashboard#1453

Merged
rdevoogtatstariongroup merged 1 commit into
developmentfrom
feat/gh734-DashboardAddSubscribedParameters
Jun 29, 2026
Merged

Feat #734 added the possibility to drag a subscribed parameter into the dashboard#1453
rdevoogtatstariongroup merged 1 commit into
developmentfrom
feat/gh734-DashboardAddSubscribedParameters

Conversation

@rdevoogtatstariongroup

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-IME code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Feat #734
Dragging a subscribed parameter puts a ParameterSubscription on the drag payload. The dashboard's DragOver/Drop only matched Parameter/ParameterOverride, so the drop was rejected.

  • Added GetParameterOrOverrideBase returns the payload itself for a ParameterOrOverrideBase, or parameterSubscription.Container as ParameterOrOverrideBase for a ParameterSubscription.
  • DragOver / Drop now resolve via that helper and branch on the resolved Parameter/ParameterOverride type. Drop also folds the iteration check into the early-return guard.

added the possibility to drag a subscribed parameter into the dashboard
@rdevoogtatstariongroup
rdevoogtatstariongroup force-pushed the feat/gh734-DashboardAddSubscribedParameters branch from 3fdbd67 to 491922a Compare June 29, 2026 14:47
@rdevoogtatstariongroup
rdevoogtatstariongroup merged commit b233572 into development Jun 29, 2026
2 checks passed
@rdevoogtatstariongroup
rdevoogtatstariongroup deleted the feat/gh734-DashboardAddSubscribedParameters branch June 29, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard - when a parameter is subscribed to it is not possible to add this parameter to the dashboard

2 participants