fix #611 No longer possible to open a model with a not-active domain of expertise#1454
Merged
rdevoogtatstariongroup merged 2 commits intoJun 29, 2026
Merged
Conversation
rdevoogtatstariongroup
requested review from
lxatstariongroup and
samatstariongroup
June 29, 2026 12:17
samatstariongroup
requested changes
Jun 29, 2026
rdevoogtatstariongroup
force-pushed
the
feat/gh611-OpeningModelNonActiveDomain
branch
from
June 29, 2026 14:57
c938e29 to
eb6ba3a
Compare
samatstariongroup
approved these changes
Jun 29, 2026
rdevoogtatstariongroup
deleted the
feat/gh611-OpeningModelNonActiveDomain
branch
June 29, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #611
It is no longer possible to open an engineering model under a domain of expertise that isn't valid for that model. Previously the "Open"/double-click path auto-selected a domain (the active person's default, falling back to the first assigned one) without checking it was both assigned to the participant and still active in the model, so a user whose default domain had been de-activated would open the model into an unusable state where nothing could be owned or edited.
Now the selectable domains are restricted to participant.Domain and EngineeringModelSetup.ActiveDomain: the model opens directly only when the default domain is valid, routes to the iteration-selection screen when another usable domain exists, and is blocked with a clear message when the user has no active domain at all.