Add fused AdamW option and warn on torch attention mask memory usage#1270
Merged
SWivid merged 2 commits intoSWivid:mainfrom Mar 4, 2026
Merged
Add fused AdamW option and warn on torch attention mask memory usage#1270SWivid merged 2 commits intoSWivid:mainfrom
SWivid merged 2 commits intoSWivid:mainfrom
Conversation
Collaborator
ZhikangNiu
commented
Mar 2, 2026
ZhikangNiu
commented
- add optim.use_fused_adamw to training configs, train.py, finetune CLI and Gradio
- disallow enabling bnb_optimizer and use_fused_adamw at the same time
- warn when attn_mask_enabled=True with attn_backend=torch due to high GPU memory usage
- add optim.use_fused_adamw to training configs, train.py, finetune CLI and Gradio - disallow enabling bnb_optimizer and use_fused_adamw at the same time - warn when attn_mask_enabled=True with attn_backend=torch due to high GPU memory usage
Collaborator
Author
|
cc @SWivid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.