remove ineffective ThreadPoolExecutor in infer_batch_process#1281
Merged
SWivid merged 1 commit intoSWivid:mainfrom Mar 24, 2026
Merged
Conversation
process_batch is a generator function, so submitting it to a thread pool only creates a generator object without running any inference code. all actual work happens sequentially in the main thread when next() is called. also removes the always-true 'if result:' guard on a generator object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_batch is a generator function, so executor.submit(process_batch, gen_text) just creates a generator object in the thread without running any of the function body. all the actual inference runs in the main thread when next(result) is called. the thread pool brings no parallelism here.
also, the
if result:check is always True since a generator object is always truthy, even when empty.fix: replace the ThreadPoolExecutor loop with a plain sequential loop, which matches what actually happens. also removes the unused import.