Cute objects in cute bomb no longer repeat#10
Open
hoppermeister wants to merge 1 commit intomasterfrom
Open
Conversation
SammyIsra
requested changes
Feb 21, 2017
Owner
SammyIsra
left a comment
SammyIsra
left a comment
There was a problem hiding this comment.
How does this prevent cute bombs to have repeated links? Also, can you prevent super huge bombs? Ideally, no one would get a 20+ bomb.
SammyIsra
requested changes
Feb 21, 2017
Owner
SammyIsra
left a comment
SammyIsra
left a comment
There was a problem hiding this comment.
Also, since we have a limit of 10k history on Slack, can you aggregate all links into a single message and send it once? Instead of sending one message per ink.
Collaborator
Author
|
Super late but no- putting all of the links in one message would only have one thumbnail, ruining the point of the 'bomb' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.