Keep the Project Attributes When Fastlane Writes the Project - #199
Merged
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
Fastlane opens and saves the Xcode project to set the bundle identifier and the build number, using a project parser that drops attributes it does not know. It does not know two attributes this project relies on, and reports both while deploying:
Opening and saving the project with that parser, with no other change, removes the
traitsentry and all fourdstSubfolderentries. The traits select the package products this app builds against, and the destinations are the ones that embed the watch app and the foundation extensions, so a deployment archives from a project that differs from the one in the repository.No related issue was identified.
⚙️ Release Notes
📚 Documentation
fastlane/xcodeproj_patch.rbrecords why it exists and when it can be removed.✅ Testing
traitsentry and all fourdstSubfolderentries, and to keep every one of them byte for byte with this change in placereuse lint, and the Fastfile and the patch parseCode of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: