Scope the User Interface Test Build to Its Own Derived Data - #200
Merged
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
The user interface test build writes to the shared derived data directory of the machine it runs on, which every other run on that self-hosted runner writes to as well. When two runs overlap, or when one is cancelled part way through a build, the next run reads a precompiled module that no longer matches the module map it was built from, and the build fails before compiling anything of ours:
This is the only build in this repository that does not name a derived data path, so it is the only one exposed to it. It happened on the deployment run for the previous change, and re-running the same commit with no edit at all succeeded, which is the signature of a shared cache rather than anything in the project.
The same file also carries a job that was commented out when the user interface tests moved to the sharded build and run they use today. It has been dead since.
No related issue was identified.
⚙️ Release Notes
📚 Documentation
No documentation changes are required.
✅ Testing
actionlintCode of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: